[jira] [Resolved] (BEAM-2736) Dataflow ValidatesRunner tests are failing MetricsTests

["Thomas Groh (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-2736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Groh resolved BEAM-2736.
-------------------------------
       Resolution: Fixed
    Fix Version/s: Not applicable

This was a misconfiguration. The dataflow batch runner previously incorrectly reported tentative metrics as "attempted", but now (correctly) does not, so the tests that attempted metrics are correct should not be executed against the batch runner.

> Dataflow ValidatesRunner tests are failing MetricsTests
> -------------------------------------------------------
>
>                 Key: BEAM-2736
>                 URL: https://issues.apache.org/jira/browse/BEAM-2736
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-dataflow
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>             Fix For: Not applicable
>
>
> The tests testAttemptedCounterMetrics, testBoundedSourceMetrics, testUnboundedSourceMetrics all look for attempted metrics at a step in the pipeline. The Pipeline produces metrics with appropriate values.
> This may be a simple misconfiguration, and the batch suite of {{ValidatesRunner}} tests should suppress "attempted" values (my understanding is that as of pipeline completion only committed values should be returned.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)