[GitHub] [doris] yinzhijian commented on a diff in pull request #10483: [fix](nereids) fix some bugs in group

[GitBox <gi...@apache.org>]

yinzhijian commented on code in PR #10483:
URL: https://github.com/apache/doris/pull/10483#discussion_r909368594


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Group.java:
##########
@@ -184,7 +184,7 @@ public void setExplored(boolean explored) {
      * @return {@link Optional} of cost and {@link GroupExpression} of physical plan pair.
      */
     public Optional<Pair<Double, GroupExpression>> getLowestCostPlan(PhysicalProperties physicalProperties) {
-        if (physicalProperties == null || lowestCostPlans.isEmpty()) {
+        if (physicalProperties == null || lowestCostPlans == null || lowestCostPlans.isEmpty()) {

Review Comment:
   Well, the latest version has initialized it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org