You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/24 08:25:22 UTC

[GitHub] [pulsar] eolivelli commented on a change in pull request #12025: violation of isolation when using bookie affinity group

eolivelli commented on a change in pull request #12025:
URL: https://github.com/apache/pulsar/pull/12025#discussion_r715416708



##########
File path: pulsar-zookeeper-utils/src/test/java/org/apache/pulsar/zookeeper/ZkIsolatedBookieEnsemblePlacementPolicyTest.java
##########
@@ -137,9 +167,12 @@ public void testBasic() throws Exception {
 
         Set<BookieId> bookieToExclude = new HashSet<>();
         bookieToExclude.add(new BookieSocketAddress(BOOKIE1).toBookieId());
-        ensemble = isolationPolicy.newEnsemble(2, 2, 2, Collections.emptyMap(), bookieToExclude).getResult();
-        assertTrue(ensemble.contains(new BookieSocketAddress(BOOKIE4).toBookieId()));
-        assertTrue(ensemble.contains(new BookieSocketAddress(BOOKIE2).toBookieId()));
+        try {

Review comment:
       good




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org