You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by NightOwl888 <gi...@git.apache.org> on 2016/08/07 18:50:13 UTC
[GitHub] lucenenet pull request #178: Ported Core.Codecs.Perfield.TestPerFieldPosting...
GitHub user NightOwl888 opened a pull request:
https://github.com/apache/lucenenet/pull/178
Ported Core.Codecs.Perfield.TestPerFieldPostingsFormat2
Ported the Core.Codecs.Perfield.TestPerFieldPostingsFormat2 tests and removed [Test] attribute from a couple of methods where it didn't belong (methods that are called from other tests).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NightOwl888/lucenenet core-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucenenet/pull/178.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #178
----
commit 4d0877f25d0158a5299ffa83b67c1e3b03b2e600
Author: Shad Storhaug <sh...@shadstorhaug.com>
Date: 2016-08-07T18:45:50Z
Ported Core.Codecs.Perfield.TestPerFieldPostingsFormat2 tests and removed [Test] attribute from 2 non-tests.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet issue #178: Ported Core.Codecs.Perfield.TestPerFieldPostingsFormat...
Posted by synhershko <gi...@git.apache.org>.
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/178
Looks great! I'm not sure about the dependency of TestFramework in the Codecs subproject - is this like that in the original Java code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet issue #178: Ported Core.Codecs.Perfield.TestPerFieldPostingsFormat...
Posted by synhershko <gi...@git.apache.org>.
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/178
Merged, if that dependency will cause issues we will handle it then
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet pull request #178: Ported Core.Codecs.Perfield.TestPerFieldPosting...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/lucenenet/pull/178
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet issue #178: Ported Core.Codecs.Perfield.TestPerFieldPostingsFormat...
Posted by NightOwl888 <gi...@git.apache.org>.
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/178
Not sure if that dependency was there or not in the original, but in a more recent commit I have removed the JavaCompatibility namespace entirely so that line has also been removed. Just the namespace though, left the directory and all files in place. Its just easier if all of the extension methods "just work" without having to reference another namespace from the test environment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---