You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Andreas Kohn <an...@gmail.com> on 2013/10/29 19:37:37 UTC
Review Request 15040: Fix reversed condition in
AuthCodeGrantValidator#validateRequest()
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15040/
-----------------------------------------------------------
Review request for shindig.
Bugs: SHINDIG-1943
https://issues.apache.org/jira/browse/SHINDIG-1943
Repository: shindig
Description
-------
Reverse the condition when validating the request callback URI to match the OAuth spec.
Diffs
-----
trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth2/package-info.java PRE-CREATION
trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth2/validators/AuthCodeGrantValidator.java 1536829
Diff: https://reviews.apache.org/r/15040/diff/
Testing
-------
Local implementation of an oauth commandline client and independent web application client can authenticate/authorize properly.
Thanks,
Andreas Kohn
Re: Review Request 15040: Fix reversed condition in
AuthCodeGrantValidator#validateRequest()
Posted by Ryan Baxter <rb...@gmail.com>.
> On Nov. 1, 2013, 8:33 p.m., Ryan Baxter wrote:
> > Committed revision 1538053.
> >
> > I fixed the whitespace and also added the license header to the package-info.java file.
Please close the review.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15040/#review28031
-----------------------------------------------------------
On Oct. 29, 2013, 6:37 p.m., Andreas Kohn wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15040/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 6:37 p.m.)
>
>
> Review request for shindig.
>
>
> Bugs: SHINDIG-1943
> https://issues.apache.org/jira/browse/SHINDIG-1943
>
>
> Repository: shindig
>
>
> Description
> -------
>
> Reverse the condition when validating the request callback URI to match the OAuth spec.
>
>
> Diffs
> -----
>
> trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth2/package-info.java PRE-CREATION
> trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth2/validators/AuthCodeGrantValidator.java 1536829
>
> Diff: https://reviews.apache.org/r/15040/diff/
>
>
> Testing
> -------
>
> Local implementation of an oauth commandline client and independent web application client can authenticate/authorize properly.
>
>
> Thanks,
>
> Andreas Kohn
>
>
Re: Review Request 15040: Fix reversed condition in
AuthCodeGrantValidator#validateRequest()
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15040/#review28031
-----------------------------------------------------------
Ship it!
Committed revision 1538053.
I fixed the whitespace and also added the license header to the package-info.java file.
- Ryan Baxter
On Oct. 29, 2013, 6:37 p.m., Andreas Kohn wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15040/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 6:37 p.m.)
>
>
> Review request for shindig.
>
>
> Bugs: SHINDIG-1943
> https://issues.apache.org/jira/browse/SHINDIG-1943
>
>
> Repository: shindig
>
>
> Description
> -------
>
> Reverse the condition when validating the request callback URI to match the OAuth spec.
>
>
> Diffs
> -----
>
> trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth2/package-info.java PRE-CREATION
> trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth2/validators/AuthCodeGrantValidator.java 1536829
>
> Diff: https://reviews.apache.org/r/15040/diff/
>
>
> Testing
> -------
>
> Local implementation of an oauth commandline client and independent web application client can authenticate/authorize properly.
>
>
> Thanks,
>
> Andreas Kohn
>
>