You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Brock Noland (Code Review)" <ge...@cloudera.org> on 2016/09/23 02:05:13 UTC
[kudu-CR] [WIP][python] KUDU-1563. Add support for INSERT IGNORE
Brock Noland has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4522
Change subject: [WIP][python] KUDU-1563. Add support for INSERT IGNORE
......................................................................
[WIP][python] KUDU-1563. Add support for INSERT IGNORE
Implements python support for the `INSERT IGNORE' operation
TODO - tests
Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
3 files changed, 24 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/4522/1
--
To view, visit http://gerrit.cloudera.org:8080/4522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>
[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.
Change subject: [python] KUDU-1563. Add support for INSERT IGNORE
......................................................................
Patch Set 10:
Is this still going on?
--
To view, visit http://gerrit.cloudera.org:8080/4522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE
Posted by "Brock Noland (Code Review)" <ge...@cloudera.org>.
Hello David Ribeiro Alves, Kudu Jenkins, Jordan Birdsell, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4522
to look at the new patch set (#15).
Change subject: [python] KUDU-1563. Add support for INSERT IGNORE
......................................................................
[python] KUDU-1563. Add support for INSERT IGNORE
Implements python support for the `INSERT IGNORE' operation
Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
4 files changed, 39 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/4522/15
--
To view, visit http://gerrit.cloudera.org:8080/4522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
Gerrit-Change-Number: 4522
Gerrit-PatchSet: 15
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE
Posted by "Brock Noland (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4522
to look at the new patch set (#3).
Change subject: [python] KUDU-1563. Add support for INSERT IGNORE
......................................................................
[python] KUDU-1563. Add support for INSERT IGNORE
Implements python support for the `INSERT IGNORE' operation
Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
4 files changed, 37 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/4522/3
--
To view, visit http://gerrit.cloudera.org:8080/4522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE
Posted by "Brock Noland (Code Review)" <ge...@cloudera.org>.
Brock Noland has posted comments on this change.
Change subject: [python] KUDU-1563. Add support for INSERT IGNORE
......................................................................
Patch Set 5:
(2 comments)
Thank you!
http://gerrit.cloudera.org:8080/#/c/4522/5/python/kudu/tests/test_client.py
File python/kudu/tests/test_client.py:
PS5, Line 164: self.assertRaises(Exception, session.apply, op)
> I think this test would now fail since the last write op will be an insert
Good catch!
PS5, Line 187: op = table.new_update()
> Is this supposed to be new_insert_ignore?
Done
--
To view, visit http://gerrit.cloudera.org:8080/4522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE
Posted by "Brock Noland (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4522
to look at the new patch set (#6).
Change subject: [python] KUDU-1563. Add support for INSERT IGNORE
......................................................................
[python] KUDU-1563. Add support for INSERT IGNORE
Implements python support for the `INSERT IGNORE' operation
Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
4 files changed, 37 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/4522/6
--
To view, visit http://gerrit.cloudera.org:8080/4522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE
Posted by "Brock Noland (Code Review)" <ge...@cloudera.org>.
Brock Noland has posted comments on this change.
Change subject: [python] KUDU-1563. Add support for INSERT IGNORE
......................................................................
Patch Set 10:
Yep. I've been a little busy but I plan to get back to this. Should have some time this week. Maybe even tonight.
--
To view, visit http://gerrit.cloudera.org:8080/4522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/4522 )
Change subject: [python] KUDU-1563. Add support for INSERT_IGNORE
......................................................................
Patch Set 21: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
Gerrit-Change-Number: 4522
Gerrit-PatchSet: 21
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 18 Feb 2020 20:46:35 +0000
Gerrit-HasComments: No
[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has uploaded a new patch set (#19) to the change originally created by Brock Noland. ( http://gerrit.cloudera.org:8080/4522 )
Change subject: [python] KUDU-1563. Add support for INSERT_IGNORE
......................................................................
[python] KUDU-1563. Add support for INSERT_IGNORE
Implements Python support for the `INSERT_IGNORE' operation.
Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
4 files changed, 36 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/4522/19
--
To view, visit http://gerrit.cloudera.org:8080/4522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
Gerrit-Change-Number: 4522
Gerrit-PatchSet: 19
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.
Change subject: [python] KUDU-1563. Add support for INSERT IGNORE
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE
Posted by "Brock Noland (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4522
to look at the new patch set (#4).
Change subject: [python] KUDU-1563. Add support for INSERT IGNORE
......................................................................
[python] KUDU-1563. Add support for INSERT IGNORE
Implements python support for the `INSERT IGNORE' operation
Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
4 files changed, 37 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/4522/4
--
To view, visit http://gerrit.cloudera.org:8080/4522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has uploaded a new patch set (#21) to the change originally created by Brock Noland. ( http://gerrit.cloudera.org:8080/4522 )
Change subject: [python] KUDU-1563. Add support for INSERT_IGNORE
......................................................................
[python] KUDU-1563. Add support for INSERT_IGNORE
Implements Python support for the `INSERT_IGNORE' operation.
Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
4 files changed, 44 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/4522/21
--
To view, visit http://gerrit.cloudera.org:8080/4522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
Gerrit-Change-Number: 4522
Gerrit-PatchSet: 21
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.
Change subject: [python] KUDU-1563. Add support for INSERT IGNORE
......................................................................
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4522/5/python/kudu/tests/test_client.py
File python/kudu/tests/test_client.py:
PS5, Line 164: self.assertRaises(Exception, session.apply, op)
I think this test would now fail since the last write op will be an insert ignore. Maybe flip the insert ignore to be on even rows?
PS5, Line 187: op = table.new_update()
Is this supposed to be new_insert_ignore?
--
To view, visit http://gerrit.cloudera.org:8080/4522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE
Posted by "Brock Noland (Code Review)" <ge...@cloudera.org>.
Hello David Ribeiro Alves, Kudu Jenkins, Jordan Birdsell, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4522
to look at the new patch set (#16).
Change subject: [python] KUDU-1563. Add support for INSERT IGNORE
......................................................................
[python] KUDU-1563. Add support for INSERT IGNORE
Implements python support for the `INSERT IGNORE' operation
Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
4 files changed, 36 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/4522/16
--
To view, visit http://gerrit.cloudera.org:8080/4522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
Gerrit-Change-Number: 4522
Gerrit-PatchSet: 16
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.
Change subject: [python] KUDU-1563. Add support for INSERT IGNORE
......................................................................
Patch Set 9:
This will need a good rebasing, the writeop api has since changed on the python side.
--
To view, visit http://gerrit.cloudera.org:8080/4522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE
Posted by "Brock Noland (Code Review)" <ge...@cloudera.org>.
Hello Jordan Birdsell, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4522
to look at the new patch set (#10).
Change subject: [python] KUDU-1563. Add support for INSERT IGNORE
......................................................................
[python] KUDU-1563. Add support for INSERT IGNORE
Implements python support for the `INSERT IGNORE' operation
Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
4 files changed, 39 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/4522/10
--
To view, visit http://gerrit.cloudera.org:8080/4522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/4522 )
Change subject: [python] KUDU-1563. Add support for INSERT_IGNORE
......................................................................
[python] KUDU-1563. Add support for INSERT_IGNORE
Implements Python support for the `INSERT_IGNORE' operation.
Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
Reviewed-on: http://gerrit.cloudera.org:8080/4522
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
4 files changed, 44 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/4522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
Gerrit-Change-Number: 4522
Gerrit-PatchSet: 22
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/4522 )
Change subject: [python] KUDU-1563. Add support for INSERT_IGNORE
......................................................................
Patch Set 20:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4522/20/python/kudu/client.pyx
File python/kudu/client.pyx:
http://gerrit.cloudera.org:8080/#/c/4522/20/python/kudu/client.pyx@846
PS20, Line 846: def new_insert_ignore(self, record):
> Should we allow record to be None as for the other new_*** functions?
Done
http://gerrit.cloudera.org:8080/#/c/4522/20/python/kudu/client.pyx@848
PS20, Line 848: Create a new Insert Ignore operation. Pass the completed Insert Ignore to a Session.
> Seems like there's more docs that can be cribbed from the other new_*** fun
Done
--
To view, visit http://gerrit.cloudera.org:8080/4522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
Gerrit-Change-Number: 4522
Gerrit-PatchSet: 20
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 18 Feb 2020 16:03:36 +0000
Gerrit-HasComments: Yes
[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/4522 )
Change subject: [python] KUDU-1563. Add support for INSERT_IGNORE
......................................................................
Patch Set 20:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4522/20/python/kudu/client.pyx
File python/kudu/client.pyx:
http://gerrit.cloudera.org:8080/#/c/4522/20/python/kudu/client.pyx@846
PS20, Line 846: def new_insert_ignore(self, record):
Should we allow record to be None as for the other new_*** functions?
http://gerrit.cloudera.org:8080/#/c/4522/20/python/kudu/client.pyx@848
PS20, Line 848: Create a new Insert Ignore operation. Pass the completed Insert Ignore to a Session.
Seems like there's more docs that can be cribbed from the other new_*** functions.
--
To view, visit http://gerrit.cloudera.org:8080/4522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
Gerrit-Change-Number: 4522
Gerrit-PatchSet: 20
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 18 Feb 2020 02:21:32 +0000
Gerrit-HasComments: Yes