[jira] [Commented] (PHOENIX-53) Replace CSV loader with Apache Commons CSV loader

["James Taylor (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919190#comment-13919190 ] 

James Taylor commented on PHOENIX-53:
-------------------------------------

Patch applied cleanly and tests pass. Nice work, [~jviolette123]. I checked it in for you. Thanks!

For the release, I need a source jar to go with the/apache-phoenix/phoenix-core/lib/commons-csv-1.0-SNAPSHOT.jar. 

Would you mind getting that for me?



> Replace CSV loader with Apache Commons CSV loader
> -------------------------------------------------
>
>                 Key: PHOENIX-53
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-53
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 2.2.3, 3.0.0
>            Reporter: James Violette
>              Labels: patch
>             Fix For: 2.2.3, 3.0.0
>
>         Attachments: commons-csv-1.0-SNAPSHOT.jar, incubator-phoenix-commons-csv-rev1.patch, incubator-phoenix-commons-csv-rev2-3.0.0.patch, incubator-phoenix-commons-csv-rev2-3.0.0.patch, incubator-phoenix-csv-commons.patch
>
>
> in org.apache.phoenix.util.CSVLoader, the upsert fails if it encounters an empty line.  This occurs if all lines end with the new line character and the reader returns an empty line at the end.
> A fix is to add a guard while reading the next line.
> 	public void upsert(CSVReader reader) throws Exception {
>    ...
>     		while ((nextLine = reader.readNext()) != null) {
>     			if (nextLine.length==0) {
>     				continue;
>     			}



--
This message was sent by Atlassian JIRA
(v6.2#6252)