You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2026/07/16 13:25:11 UTC

(camel) 01/02: CAMEL-24135: camel-resilience4j - Fix JMX slow successful calls returning total slow calls, and console hiding failure counts

This is an automated email from the ASF dual-hosted git repository.

davsclaus pushed a commit to branch fix/CAMEL-24136
in repository https://gitbox.apache.org/repos/asf/camel.git

commit b456b3dfbc1b5b1b60f5b7cc652672b3962c6c7d
Author: Claus Ibsen <cl...@gmail.com>
AuthorDate: Thu Jul 16 14:56:04 2026 +0200

    CAMEL-24135: camel-resilience4j - Fix JMX slow successful calls returning total slow calls, and console hiding failure counts
    
    Co-Authored-By: Claude Opus 4.6 <no...@anthropic.com>
    Signed-off-by: Claus Ibsen <cl...@gmail.com>
---
 .../org/apache/camel/component/resilience4j/ResilienceConsole.java  | 6 +++---
 .../apache/camel/component/resilience4j/ResilienceProcessor.java    | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/components/camel-resilience4j/src/main/java/org/apache/camel/component/resilience4j/ResilienceConsole.java b/components/camel-resilience4j/src/main/java/org/apache/camel/component/resilience4j/ResilienceConsole.java
index e9dc6e21b71b..ae0af7cf6590 100644
--- a/components/camel-resilience4j/src/main/java/org/apache/camel/component/resilience4j/ResilienceConsole.java
+++ b/components/camel-resilience4j/src/main/java/org/apache/camel/component/resilience4j/ResilienceConsole.java
@@ -60,12 +60,12 @@ public class ResilienceConsole extends AbstractDevConsole {
             int fc = cb.getNumberOfFailedCalls();
             long npc = cb.getNumberOfNotPermittedCalls();
             float fr = cb.getFailureRate();
-            if (fr > 0) {
+            if (fr >= 0) {
                 sb.append(String.format("    %s/%s: %s (buffered: %d success: %d failure: %d/%.0f%% not-permitted: %d)%n", rid,
                         id, state, bc, sc, fc, fr, npc));
             } else {
-                sb.append(String.format("    %s/%s: %s (buffered: %d success: %d failure: 0 not-permitted: %d)%n", rid, id,
-                        state, bc, sc, npc));
+                sb.append(String.format("    %s/%s: %s (buffered: %d success: %d failure: %d not-permitted: %d)%n", rid, id,
+                        state, bc, sc, fc, npc));
             }
         }
 
diff --git a/components/camel-resilience4j/src/main/java/org/apache/camel/component/resilience4j/ResilienceProcessor.java b/components/camel-resilience4j/src/main/java/org/apache/camel/component/resilience4j/ResilienceProcessor.java
index aa2e1c8dead5..19ebe725f081 100644
--- a/components/camel-resilience4j/src/main/java/org/apache/camel/component/resilience4j/ResilienceProcessor.java
+++ b/components/camel-resilience4j/src/main/java/org/apache/camel/component/resilience4j/ResilienceProcessor.java
@@ -314,7 +314,7 @@ public class ResilienceProcessor extends BaseProcessorSupport
     @ManagedAttribute(description = "Returns the current number of successful calls which were slower than a certain threshold.")
     public int getNumberOfSlowSuccessfulCalls() {
         if (circuitBreaker != null) {
-            return circuitBreaker.getMetrics().getNumberOfSlowCalls();
+            return circuitBreaker.getMetrics().getNumberOfSlowSuccessfulCalls();
         } else {
             return 0;
         }