You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/08/02 00:57:55 UTC
Review Request 61334: Imported `http_parser` library.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61334/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Imported `http_parser` library.
Diffs
-----
3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063
Diff: https://reviews.apache.org/r/61334/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 61334: Imported `http_parser` library.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61334/#review184422
-----------------------------------------------------------
Ship it!
May possibly squash into https://reviews.apache.org/r/61291/ before committing.
- Joseph Wu
On Aug. 9, 2017, 7:55 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61334/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2017, 7:55 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/61334
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063
>
>
> Diff: https://reviews.apache.org/r/61334/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61334: Imported `http_parser` library.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61334/
-----------------------------------------------------------
(Updated Aug. 9, 2017, 7:55 p.m.)
Review request for mesos.
Changes
-------
The `UPDATE` command is unconditionally run, causing what appears to break incremental builds. It causes the install step (a noop) to be repeated, but that updates the target, and so causes libprocess to be relinked and so forth. The patch command is run once and only once, and really, what we're doing here (adding a file to the source tree) _is_ patching the source tree.
Repository: mesos
Description (updated)
-------
Review: https://reviews.apache.org/r/61334
Diffs (updated)
-----
3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063
Diff: https://reviews.apache.org/r/61334/diff/2/
Changes: https://reviews.apache.org/r/61334/diff/1-2/
Testing
-------
Thanks,
Andrew Schwartzmeyer