You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Guillaume Nodet (JIRA)" <ji...@apache.org> on 2008/03/27 09:33:24 UTC
[jira] Created: (GSHELL-107) Make IO an interface instead of a
class
Make IO an interface instead of a class
---------------------------------------
Key: GSHELL-107
URL: https://issues.apache.org/jira/browse/GSHELL-107
Project: GShell
Issue Type: Improvement
Security Level: public (Regular issues)
Reporter: Guillaume Nodet
Assignee: Jason Dillon
The fields io.in, io.out. io.err are usually accessed directly which makes things uneasy to override.
Using an interface with getters would be cleaner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GSHELL-107) Make IO an interface instead of a
class
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GSHELL-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582588#action_12582588 ]
Guillaume Nodet commented on GSHELL-107:
----------------------------------------
I think the whole problems comes from the way the remote shell is created / initialized.
Lots of the related classes are given a pointer to an IO and / or Environment, which implies they have to be created on demand. In ServiceMix, we use spring to wire things together at startup instead of creating these classes on demand, so i need to feed them with proxies that delegate to thread local storage. The real problem is that proxying fields is not really possible.
It seems to comes down to the fact that the CommandExecutor does not take an IO as an argument, so you can not reuse it.
I think this would make the api cleaner, but it's no big deal, as I already have a workaround.
> Make IO an interface instead of a class
> ---------------------------------------
>
> Key: GSHELL-107
> URL: https://issues.apache.org/jira/browse/GSHELL-107
> Project: GShell
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Reporter: Guillaume Nodet
> Assignee: Jason Dillon
>
> The fields io.in, io.out. io.err are usually accessed directly which makes things uneasy to override.
> Using an interface with getters would be cleaner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GSHELL-107) Make IO an interface instead of a
class
Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GSHELL-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Dillon updated GSHELL-107:
--------------------------------
Component/s: Core
> Make IO an interface instead of a class
> ---------------------------------------
>
> Key: GSHELL-107
> URL: https://issues.apache.org/jira/browse/GSHELL-107
> Project: GShell
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Core
> Reporter: Guillaume Nodet
> Assignee: Jason Dillon
>
> The fields io.in, io.out. io.err are usually accessed directly which makes things uneasy to override.
> Using an interface with getters would be cleaner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GSHELL-107) Make IO an interface instead of a
class
Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GSHELL-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582558#action_12582558 ]
Jason Dillon commented on GSHELL-107:
-------------------------------------
Why do you want to override these?
> Make IO an interface instead of a class
> ---------------------------------------
>
> Key: GSHELL-107
> URL: https://issues.apache.org/jira/browse/GSHELL-107
> Project: GShell
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Reporter: Guillaume Nodet
> Assignee: Jason Dillon
>
> The fields io.in, io.out. io.err are usually accessed directly which makes things uneasy to override.
> Using an interface with getters would be cleaner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GSHELL-107) Make IO an interface instead of a
class
Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GSHELL-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Dillon updated GSHELL-107:
--------------------------------
Component/s: (was: Core)
Support - IO
Fix Version/s: 1.0-alpha-3
> Make IO an interface instead of a class
> ---------------------------------------
>
> Key: GSHELL-107
> URL: https://issues.apache.org/jira/browse/GSHELL-107
> Project: GShell
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Support - IO
> Reporter: Guillaume Nodet
> Assignee: Jason Dillon
> Fix For: 1.0-alpha-3
>
>
> The fields io.in, io.out. io.err are usually accessed directly which makes things uneasy to override.
> Using an interface with getters would be cleaner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.