You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Branimir Lambov (JIRA)" <ji...@apache.org> on 2016/05/03 18:09:12 UTC

[jira] [Commented] (CASSANDRA-11518) o.a.c.utils.UUIDGen clock generation is not very high in entropy

    [ https://issues.apache.org/jira/browse/CASSANDRA-11518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268956#comment-15268956 ] 

Branimir Lambov commented on CASSANDRA-11518:
---------------------------------------------

LGTM

> o.a.c.utils.UUIDGen clock generation is not very high in entropy
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-11518
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11518
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Ariel Weisberg
>            Assignee: Ariel Weisberg
>            Priority: Trivial
>             Fix For: 3.0.x, 3.x
>
>
> makeClockSeqAndNode uses {{java.util.Random}} to generate the clock. {{Random}} only has 48-bits of internal state so it's not going to generate the best bits for clock and in addition to that it uses a collision prone seed that sort of defeats the purpose of clock sequence.
> A better approach to get the most out of those 14-bits would be to use {{SecureRandom}} with something like SHA1PRNG.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)