You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/11/26 16:06:22 UTC
[GitHub] [kafka] dajac commented on a change in pull request #9630: KAFKA-10739; Replace EpochEndOffset with automated protocol
dajac commented on a change in pull request #9630:
URL: https://github.com/apache/kafka/pull/9630#discussion_r531123360
##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -1862,23 +1864,51 @@ class ReplicaManager(val config: KafkaConfig,
}
}
- def lastOffsetForLeaderEpoch(requestedEpochInfo: Map[TopicPartition, OffsetsForLeaderEpochRequest.PartitionData]): Map[TopicPartition, EpochEndOffset] = {
- requestedEpochInfo.map { case (tp, partitionData) =>
- val epochEndOffset = getPartition(tp) match {
- case HostedPartition.Online(partition) =>
- partition.lastOffsetForLeaderEpoch(partitionData.currentLeaderEpoch, partitionData.leaderEpoch,
- fetchOnlyFromLeader = true)
-
- case HostedPartition.Offline =>
- new EpochEndOffset(Errors.KAFKA_STORAGE_ERROR, UNDEFINED_EPOCH, UNDEFINED_EPOCH_OFFSET)
-
- case HostedPartition.None if metadataCache.contains(tp) =>
- new EpochEndOffset(Errors.NOT_LEADER_OR_FOLLOWER, UNDEFINED_EPOCH, UNDEFINED_EPOCH_OFFSET)
-
- case HostedPartition.None =>
- new EpochEndOffset(Errors.UNKNOWN_TOPIC_OR_PARTITION, UNDEFINED_EPOCH, UNDEFINED_EPOCH_OFFSET)
+ def lastOffsetForLeaderEpoch(
+ requestedEpochInfo: Seq[OffsetForLeaderTopic]
+ ): Seq[OffsetForLeaderTopicResult] = {
+ requestedEpochInfo.map { offsetForLeaderTopic =>
+ val partitions = offsetForLeaderTopic.partitions.asScala.map { offsetForLeaderPartition =>
Review comment:
`asScala` and `asJava` just wrap the collections to make it accessible from respectively Scala and Java. In that regards, I am not sure that we would gain much by using the stream API here as it also creates a Stream. It seems more natural to keep using Scala here. If you look in the API layer, we do this everywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org