You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/08/13 03:01:34 UTC
[kudu-CR] log block manager: replace custom RAII class with ScopedCleanup
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3965
to review the following change.
Change subject: log_block_manager: replace custom RAII class with ScopedCleanup
......................................................................
log_block_manager: replace custom RAII class with ScopedCleanup
Change-Id: I810626472adffdeafa626db3f4fc927b7c2a0b86
---
M src/kudu/fs/log_block_manager.cc
1 file changed, 4 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/3965/1
--
To view, visit http://gerrit.cloudera.org:8080/3965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I810626472adffdeafa626db3f4fc927b7c2a0b86
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] log block manager: replace custom RAII class with ScopedCleanup
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: log_block_manager: replace custom RAII class with ScopedCleanup
......................................................................
log_block_manager: replace custom RAII class with ScopedCleanup
Change-Id: I810626472adffdeafa626db3f4fc927b7c2a0b86
Reviewed-on: http://gerrit.cloudera.org:8080/3965
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/fs/log_block_manager.cc
1 file changed, 4 insertions(+), 16 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I810626472adffdeafa626db3f4fc927b7c2a0b86
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] log block manager: replace custom RAII class with ScopedCleanup
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: log_block_manager: replace custom RAII class with ScopedCleanup
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2858/
--
To view, visit http://gerrit.cloudera.org:8080/3965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I810626472adffdeafa626db3f4fc927b7c2a0b86
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] log block manager: replace custom RAII class with ScopedCleanup
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: log_block_manager: replace custom RAII class with ScopedCleanup
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I810626472adffdeafa626db3f4fc927b7c2a0b86
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No