You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@allura.apache.org by br...@apache.org on 2013/01/29 04:07:58 UTC
[2/2] git commit: [#5698] Removed unneeded invalidate_bin_counts
Updated Branches:
refs/heads/master 578a4739e -> 9f6448ee6
[#5698] Removed unneeded invalidate_bin_counts
We don't need to invalidate the bin counts when a bin is deleted,
because that bin will no longer be queried, and won't affect other
bin counts. (The Bin instance will be deleted, and those are what
control what data is pulled from Globals.bin_data, so leaving the
count data for that bin in Globals won't cause any harm.)
Project: http://git-wip-us.apache.org/repos/asf/incubator-allura/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-allura/commit/d2edbb3f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-allura/tree/d2edbb3f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-allura/diff/d2edbb3f
Branch: refs/heads/master
Commit: d2edbb3fe3db50766b9407a449431d410b211e3d
Parents: 578a473
Author: Cory Johns <jo...@geek.net>
Authored: Mon Jan 28 18:03:55 2013 +0000
Committer: Dave Brondsema <db...@geek.net>
Committed: Tue Jan 29 03:07:40 2013 +0000
----------------------------------------------------------------------
ForgeTracker/forgetracker/tracker_main.py | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-allura/blob/d2edbb3f/ForgeTracker/forgetracker/tracker_main.py
----------------------------------------------------------------------
diff --git a/ForgeTracker/forgetracker/tracker_main.py b/ForgeTracker/forgetracker/tracker_main.py
index e71bdbc..3460c24 100644
--- a/ForgeTracker/forgetracker/tracker_main.py
+++ b/ForgeTracker/forgetracker/tracker_main.py
@@ -935,7 +935,6 @@ class BinController(BaseController):
@validate(validators=dict(bin=V.Ming(TM.Bin)))
def delbin(self, bin=None):
require(lambda:bin.app_config_id==self.app.config._id)
- self.app.globals.invalidate_bin_counts()
bin.delete()
redirect(request.referer)