svn commit: r1875883 - /httpd/httpd/trunk/modules/ssl/ssl_engine_io.c

[jo...@apache.org]

Author: jorton
Date: Mon Mar 30 14:11:44 2020
New Revision: 1875883

URL: http://svn.apache.org/viewvc?rev=1875883&view=rev
Log:
* modules/ssl/ssl_engine_io.c: Update comment, no function change, [skip ci]

Modified:
    httpd/httpd/trunk/modules/ssl/ssl_engine_io.c

Modified: httpd/httpd/trunk/modules/ssl/ssl_engine_io.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/ssl/ssl_engine_io.c?rev=1875883&r1=1875882&r2=1875883&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/ssl/ssl_engine_io.c (original)
+++ httpd/httpd/trunk/modules/ssl/ssl_engine_io.c Mon Mar 30 14:11:44 2020
@@ -1678,7 +1678,14 @@ static apr_status_t ssl_io_filter_input(
  * and introducing unnecessary overhead.
  *
  * ### This buffering could be probably be done more comprehensively
- * ### in ssl_io_filter_output itself. */
+ * ### in ssl_io_filter_output itself. 
+ * 
+ * ### Another possible performance optimisation in particular for the
+ * ### [HEAP] [FILE] HTTP response case is using a brigade rather than
+ * ### a char array to buffer; using apr_brigade_write() to append
+ * ### will use already-allocated memory from the HEAP, reducing # of
+ * ### copies.
+ */
 
 #define COALESCE_BYTES (AP_IOBUFSIZE)