[jira] [Commented] (YARN-3973) Recent changes to application priority management break reservation system from YARN-1051

["Carlo Curino (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640756#comment-14640756 ] 

Carlo Curino commented on YARN-3973:
------------------------------------

[~imenache] has just reported to me a NPE when running the reservation system in current trunk (part of testing of YARN-3656). Thanks Ishai for reporting this.

[~leftnoteasy], I think this is due to YARN-2003 changes. In particular we get and NPE when running:  CapacityScheduler.getDefaultPriorityForQueue()
due to the ReservationQueue (inheriting from LeafQueue) the get getDefaultApplicationPriority() which returns null for queues that are not in the config file,
such as the dynamic queues of the reservation system. 

A possible fix is to override getDefaultApplicationPriority() in ReservationQueue to return some default priority value: 
{code}
  @Override
  public Priority getDefaultApplicationPriority() {
    return Priority.newInstance(0);
  }
{code}

But I wonder whether there is anything more principled, [~leftnoteasy] any advise?. 

> Recent changes to application priority management break reservation system from YARN-1051
> -----------------------------------------------------------------------------------------
>
>                 Key: YARN-3973
>                 URL: https://issues.apache.org/jira/browse/YARN-3973
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>            Reporter: Carlo Curino
>
> Recent changes in trunk (I think YARN-2003) produce NPE for reservation system when application is submitted to a ReservationQueue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)