You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/07 14:06:53 UTC
[GitHub] [flink] zhijiangW opened a new pull request #12511: [FLINK-18063][checkpointing] Fix the race condition for aborting current checkpoint in CheckpointBarrierUnaligner
zhijiangW opened a new pull request #12511:
URL: https://github.com/apache/flink/pull/12511
## What is the purpose of the change
There are three aborting scenarios which might encounter race condition:
1. CheckpointBarrierUnaligner#processCancellationBarrier
2. CheckpointBarrierUnaligner#processEndOfPartition
3. AlternatingCheckpointBarrierHandler#processBarrier
They only consider the pending checkpoint triggered by #processBarrier from task thread to abort it. Actually the checkpoint might also be triggered by #notifyBarrierReceived from netty thread in race condition, so we should also handle properly to abort it.
## Brief change log
- Fix the process of AlternatingCheckpointBarrierHandler#processBarrier
- Fix the process of CheckpointBarrierUnaligner#processEndOfPartition to abort checkpoint properly
- Fix the process of CheckpointBarrierUnaligner#processCancellationBarrier to abort checkpoint properly
## Verifying this change
- Added new unit test `CheckpointBarrierUnalignerTest#testProcessCancellationBarrierAfterNotifyBarrierReceived`
- Added new unit test `CheckpointBarrierUnalignerTest#testProcessCancellationBarrierAfterProcessBarrier`
- Added new unit test `CheckpointBarrierUnalignerTest#testProcessCancellationBarrierBeforeProcessAndReceiveBarrier`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12511: [FLINK-18063][checkpointing] Fix the race condition for aborting current checkpoint in CheckpointBarrierUnaligner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12511:
URL: https://github.com/apache/flink/pull/12511#issuecomment-640227792
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "72fc05396985a65f1745dccf7d39204868679303",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2879",
"triggerID" : "72fc05396985a65f1745dccf7d39204868679303",
"triggerType" : "PUSH"
}, {
"hash" : "4c0d40c3803dd7ab66fea6b03a9f5367dd4389bd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2923",
"triggerID" : "4c0d40c3803dd7ab66fea6b03a9f5367dd4389bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 72fc05396985a65f1745dccf7d39204868679303 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2879)
* 4c0d40c3803dd7ab66fea6b03a9f5367dd4389bd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2923)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12511: [FLINK-18063][checkpointing] Fix the race condition for aborting current checkpoint in CheckpointBarrierUnaligner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12511:
URL: https://github.com/apache/flink/pull/12511#issuecomment-640227792
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "72fc05396985a65f1745dccf7d39204868679303",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2879",
"triggerID" : "72fc05396985a65f1745dccf7d39204868679303",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 72fc05396985a65f1745dccf7d39204868679303 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2879)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on pull request #12511: [FLINK-18063][checkpointing] Fix the race condition for aborting current checkpoint in CheckpointBarrierUnaligner
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on pull request #12511:
URL: https://github.com/apache/flink/pull/12511#issuecomment-641172596
Cherry-pick it to master from #12406 which was reviewed and approved before.
The failure e2e is known `StreamingKafkaITCase`, so ignore it to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12511: [FLINK-18063][checkpointing] Fix the race condition for aborting current checkpoint in CheckpointBarrierUnaligner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12511:
URL: https://github.com/apache/flink/pull/12511#issuecomment-640227792
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "72fc05396985a65f1745dccf7d39204868679303",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2879",
"triggerID" : "72fc05396985a65f1745dccf7d39204868679303",
"triggerType" : "PUSH"
}, {
"hash" : "4c0d40c3803dd7ab66fea6b03a9f5367dd4389bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4c0d40c3803dd7ab66fea6b03a9f5367dd4389bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 72fc05396985a65f1745dccf7d39204868679303 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2879)
* 4c0d40c3803dd7ab66fea6b03a9f5367dd4389bd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12511: [FLINK-18063][checkpointing] Fix the race condition for aborting current checkpoint in CheckpointBarrierUnaligner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12511:
URL: https://github.com/apache/flink/pull/12511#issuecomment-640227792
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW merged pull request #12511: [FLINK-18063][checkpointing] Fix the race condition for aborting current checkpoint in CheckpointBarrierUnaligner
Posted by GitBox <gi...@apache.org>.
zhijiangW merged pull request #12511:
URL: https://github.com/apache/flink/pull/12511
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12511: [FLINK-18063][checkpointing] Fix the race condition for aborting current checkpoint in CheckpointBarrierUnaligner
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12511:
URL: https://github.com/apache/flink/pull/12511#issuecomment-640227792
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "72fc05396985a65f1745dccf7d39204868679303",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "72fc05396985a65f1745dccf7d39204868679303",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 72fc05396985a65f1745dccf7d39204868679303 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12511: [FLINK-18063][checkpointing] Fix the race condition for aborting current checkpoint in CheckpointBarrierUnaligner
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12511:
URL: https://github.com/apache/flink/pull/12511#issuecomment-640224680
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 72fc05396985a65f1745dccf7d39204868679303 (Sun Jun 07 14:09:43 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12511: [FLINK-18063][checkpointing] Fix the race condition for aborting current checkpoint in CheckpointBarrierUnaligner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12511:
URL: https://github.com/apache/flink/pull/12511#issuecomment-640227792
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "72fc05396985a65f1745dccf7d39204868679303",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2879",
"triggerID" : "72fc05396985a65f1745dccf7d39204868679303",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 72fc05396985a65f1745dccf7d39204868679303 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2879)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org