You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2026/08/06 07:35:59 UTC

[PR] [SPARK-58615][ML] Avoid FPGrowthModel temporary column conflicts [spark]

zhengruifeng opened a new pull request, #57816:
URL: https://github.com/apache/spark/pull/57816

   ### What changes were proposed in this pull request?
   
   This follow-up to #57806 gives the transient association-rules column in `FPGrowthModel.transform` a generated name instead of the fixed name `rules`. It also adds regression coverage for an input dataset that already contains a `rules` column.
   
   ### Why are the changes needed?
   
   The fixed temporary column can conflict with an input column of the same name after the join, causing ambiguous-column analysis failures or dropping the user's column.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. `FPGrowthModel.transform` now supports and preserves an input column named `rules`.
   
   ### How was this patch tested?
   
   - `build/sbt -java-home /usr/lib/jvm/java-17-openjdk-amd64 mllib/Test/compile`
   - Added `FPGrowthSuite` coverage for an input `rules` column. The focused suite has not been run locally yet.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Codex (GPT-5)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-58615][ML] Avoid FPGrowthModel temporary column conflicts [spark]

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #57816:
URL: https://github.com/apache/spark/pull/57816#issuecomment-5203012338

   **Merge Summary:**
   - merged into master https://github.com/apache/spark/commit/5aeb251f12001a32880f1fc2374ce831e3220097
   - merged into branch-4.x https://github.com/apache/spark/commit/dd11c56dbec8fdafa1187e7bc358aaaeb016129d
   
   *Posted by `merge_spark_pr.py`*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-58615][ML] Avoid FPGrowthModel temporary column conflicts [spark]

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #57816: [SPARK-58615][ML] Avoid FPGrowthModel temporary column conflicts
URL: https://github.com/apache/spark/pull/57816


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org