[jira] [Commented] (BOOKKEEPER-594) AutoRecovery shutting down on SyncDisconnected

["Ivan Kelly (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13614400#comment-13614400 ] 

Ivan Kelly commented on BOOKKEEPER-594:
---------------------------------------

I have two plans to fix this. Firstly, the autorecovery daemon shouldn't take down the bookie, even if it has gone down itself. Secondly, it shouldn't go down itself on sync disconnected. Fixing the former will be very straight forward. The latter may be tricky.
                
> AutoRecovery shutting down on SyncDisconnected
> ----------------------------------------------
>
>                 Key: BOOKKEEPER-594
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-594
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>            Priority: Critical
>             Fix For: 4.3.0
>
>
> Currently the AutoRecovery daemon will shut down on SyncDisconnected. This is the wrong behaviour. It should wait until it gets a expired signal before shutting down. If autoRecoveryDaemonEnabled=true, then the autorecovery deamon is running in the same process as the bookie, the bookie death watcher will take down the bookie at this point also, but as the bookie hasn't shutdown, exit code will be 0, which is confusing to any monitoring app.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira