You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Vladimir Zhilyaev (JIRA)" <ji...@apache.org> on 2011/01/26 16:19:44 UTC
[jira] Created: (THRIFT-1048) Thrift java library has redundant
dependency on commons-lang.
Thrift java library has redundant dependency on commons-lang.
-------------------------------------------------------------
Key: THRIFT-1048
URL: https://issues.apache.org/jira/browse/THRIFT-1048
Project: Thrift
Issue Type: Improvement
Components: Java - Library
Affects Versions: 0.5
Reporter: Vladimir Zhilyaev
The only class from commons-lang used in Thrift is org.apache.commons.lang.NotImplementedException.
It is used in org.apache.thrift.transport.AutoExpandingBufferReadTransport and in org.apache.thrift.transport.AutoExpandingBufferWriteTransport
It can be replaced with java.lang.UnsupportedOperationException like it is done in org.apache.thrift.transport.TMemoryInputTransport
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-1048) Thrift java library has redundant
dependency on commons-lang.
Posted by "Vladimir Zhilyaev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987464#action_12987464 ]
Vladimir Zhilyaev commented on THRIFT-1048:
-------------------------------------------
Shouldn't TMemoryInputTransport and AutoExpandingBufferReadTransport have consistency in implementation of write(..)?
> Thrift java library has redundant dependency on commons-lang.
> -------------------------------------------------------------
>
> Key: THRIFT-1048
> URL: https://issues.apache.org/jira/browse/THRIFT-1048
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Affects Versions: 0.5
> Reporter: Vladimir Zhilyaev
> Priority: Minor
>
> The only class from commons-lang used in Thrift is org.apache.commons.lang.NotImplementedException.
> It is used in org.apache.thrift.transport.AutoExpandingBufferReadTransport and in org.apache.thrift.transport.AutoExpandingBufferWriteTransport
> It can be replaced with java.lang.UnsupportedOperationException like it is done in org.apache.thrift.transport.TMemoryInputTransport
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-1048) Thrift java library has redundant
dependency on commons-lang.
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-1048:
----------------------------------
Priority: Minor (was: Major)
I'd accept a patch for this, though I'm not in any hurry to get it done.
> Thrift java library has redundant dependency on commons-lang.
> -------------------------------------------------------------
>
> Key: THRIFT-1048
> URL: https://issues.apache.org/jira/browse/THRIFT-1048
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Affects Versions: 0.5
> Reporter: Vladimir Zhilyaev
> Priority: Minor
>
> The only class from commons-lang used in Thrift is org.apache.commons.lang.NotImplementedException.
> It is used in org.apache.thrift.transport.AutoExpandingBufferReadTransport and in org.apache.thrift.transport.AutoExpandingBufferWriteTransport
> It can be replaced with java.lang.UnsupportedOperationException like it is done in org.apache.thrift.transport.TMemoryInputTransport
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-1048) Thrift java library has redundant
dependency on commons-lang.
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-1048.
---------------------------------
Resolution: Won't Fix
Ah, right. I knew there was some dependency.
> Thrift java library has redundant dependency on commons-lang.
> -------------------------------------------------------------
>
> Key: THRIFT-1048
> URL: https://issues.apache.org/jira/browse/THRIFT-1048
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Affects Versions: 0.5
> Reporter: Vladimir Zhilyaev
> Priority: Minor
>
> The only class from commons-lang used in Thrift is org.apache.commons.lang.NotImplementedException.
> It is used in org.apache.thrift.transport.AutoExpandingBufferReadTransport and in org.apache.thrift.transport.AutoExpandingBufferWriteTransport
> It can be replaced with java.lang.UnsupportedOperationException like it is done in org.apache.thrift.transport.TMemoryInputTransport
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-1048) Thrift java library has redundant
dependency on commons-lang.
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987288#action_12987288 ]
David Reiss commented on THRIFT-1048:
-------------------------------------
We still use it for HashCodeBuilder as well if you request a non-stub hashCode.
> Thrift java library has redundant dependency on commons-lang.
> -------------------------------------------------------------
>
> Key: THRIFT-1048
> URL: https://issues.apache.org/jira/browse/THRIFT-1048
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Affects Versions: 0.5
> Reporter: Vladimir Zhilyaev
> Priority: Minor
>
> The only class from commons-lang used in Thrift is org.apache.commons.lang.NotImplementedException.
> It is used in org.apache.thrift.transport.AutoExpandingBufferReadTransport and in org.apache.thrift.transport.AutoExpandingBufferWriteTransport
> It can be replaced with java.lang.UnsupportedOperationException like it is done in org.apache.thrift.transport.TMemoryInputTransport
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.