[jira] [Commented] (DRILL-4603) Refactor FileSystem plugin code to allow customizations

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-4603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239786#comment-15239786 ] 

ASF GitHub Bot commented on DRILL-4603:
---------------------------------------

GitHub user vkorukanti opened a pull request:

    https://github.com/apache/drill/pull/476

    DRILL-4603: Refactor FileSystem plugin code to allow customizations

    - Add a FileSystemPluginImplementationProvider to allow customizing:
      - Configuration
      - WorkspaceSchemaFactory lists
      - FormatCreator
    
    - Separate out WorkspaceSchema from WorkspaceSchemaFactory
    
    - Create a Configuration object and reuse it wherever new copied of Configuration are needed

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vkorukanti/drill DRILL-4603

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/476.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #476
    
----
commit d43f1de57cb012929e37d11f2b3f57885af8c92d
Author: Venki Korukanti <ve...@dremio.com>
Date:   2016-04-07T02:55:29Z

    DRILL-4603: Refactor FileSystem plugin code to allow customizations
    
    - Add a FileSystemPluginImplementationProvider to allow customizing:
      - Configuration
      - WorkspaceSchemaFactory lists
      - FormatCreator
    
    - Separate out WorkspaceSchema from WorkspaceSchemaFactory
    
    - Create a Configuration object and reuse it wherever new copied of Configuration are needed

----


> Refactor FileSystem plugin code to allow customizations
> -------------------------------------------------------
>
>                 Key: DRILL-4603
>                 URL: https://issues.apache.org/jira/browse/DRILL-4603
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Storage - Other
>            Reporter: Venki Korukanti
>            Assignee: Venki Korukanti
>             Fix For: 1.7.0
>
>
> Currently FileSystemPlugin is hard to extend, lot of logic for creating component implementations ({{WorkspaceSchemaFactory}}s, {{FormatCreator}, defining default workspaces and configuration (implicit to FileSystem implementation)) are hard coded in constructor.
>  
> This JIRA is to track 
>  * refactoring the FileSystemPlugin to allow custom component implementations (Configuration, WorkSpaceSchemaFactory, FileSystemSchemaFactory or FormatCreator).
>  * Share a single Hadoop {{Configuration}} object to create new {{Configuration}} objects. Creating a new {{Configuration}} without an existing copy is not efficient, because it involves scanning the classpath for *-site files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)