You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2013/04/25 02:05:23 UTC
Review Request: FLUME-2023. Flume must login to secure HBase before creating
the HTable instance
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10769/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Move the code that creates the HTable into runPrivileged call, and make sure the login is done before that.
This addresses bug FLUME-2023.
https://issues.apache.org/jira/browse/FLUME-2023
Diffs
-----
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java 31fb7ff
Diff: https://reviews.apache.org/r/10769/diff/
Testing
-------
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-2023. Flume must login to secure HBase before
creating the HTable instance
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10769/#review19693
-----------------------------------------------------------
Ship it!
+1 lgtm, I will run the unit tests and commit
- Mike Percy
On April 25, 2013, 2:22 a.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10769/
> -----------------------------------------------------------
>
> (Updated April 25, 2013, 2:22 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Move the code that creates the HTable into runPrivileged call, and make sure the login is done before that.
>
>
> This addresses bug FLUME-2023.
> https://issues.apache.org/jira/browse/FLUME-2023
>
>
> Diffs
> -----
>
> flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java 31fb7ff
>
> Diff: https://reviews.apache.org/r/10769/diff/
>
>
> Testing
> -------
>
> Manually verified.
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-2023. Flume must login to secure HBase before
creating the HTable instance
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10769/
-----------------------------------------------------------
(Updated April 25, 2013, 2:22 a.m.)
Review request for Flume.
Description
-------
Move the code that creates the HTable into runPrivileged call, and make sure the login is done before that.
This addresses bug FLUME-2023.
https://issues.apache.org/jira/browse/FLUME-2023
Diffs
-----
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java 31fb7ff
Diff: https://reviews.apache.org/r/10769/diff/
Testing (updated)
-------
Manually verified.
Thanks,
Hari Shreedharan