You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/02/21 20:14:32 UTC
[GitHub] leventov commented on a change in pull request #7121: Prohibit
Throwables.propagate()
leventov commented on a change in pull request #7121: Prohibit Throwables.propagate()
URL: https://github.com/apache/incubator-druid/pull/7121#discussion_r259097257
##########
File path: codestyle/checkstyle.xml
##########
@@ -204,6 +204,12 @@
<property name="message" value="Use org.apache.druid.server.http.HttpMediaType#TEXT_PLAIN_UTF8 instead"/>
</module>
+ <module name="Regexp">
+ <property name="format" value='^((?!throw|=).)* Throwables.propagate\('/>
+ <property name="illegalPattern" value="true"/>
+ <property name="message" value="Throw caught exception"/>
Review comment:
Message is misleading. See https://github.com/apache/incubator-druid/pull/6939#discussion_r253420659
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org