You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/04/20 16:18:52 UTC

[GitHub] [hive] wecharyu opened a new pull request, #3227: HIVE-26159: Make hive cli available from hive shell command

wecharyu opened a new pull request, #3227:
URL: https://github.com/apache/hive/pull/3227

   ### What changes were proposed in this pull request?
   
   Hive cli is the default service in hive script, but it can not start even if we use `--service cli` option now, I don't think this is what we expect from beeline.
   
   ### Why are the changes needed?
   
   Hive cli is a convenient tool to connect to hive metastore service for testing or hive taste, and the hive community seems not intend to deprecate hive cli so far.
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   No
   
   
   ### How was this patch tested?
   
   Shell script, can test on local with just `hive` command:
   ```bash
   $ $HIVE_HOME/bin/hive
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] github-actions[bot] closed pull request #3227: HIVE-26159: Make hive cli available from hive shell command

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #3227: HIVE-26159: Make hive cli available from hive shell command
URL: https://github.com/apache/hive/pull/3227


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] wecharyu commented on pull request #3227: HIVE-26159: Make hive cli available from hive shell command

Posted by GitBox <gi...@apache.org>.
wecharyu commented on PR #3227:
URL: https://github.com/apache/hive/pull/3227#issuecomment-1106112770

   @marton-bod @kgyrtkirk Could you please review this PR? The failed test seemed not related to this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] marton-bod commented on pull request #3227: HIVE-26159: Make hive cli available from hive shell command

Posted by GitBox <gi...@apache.org>.
marton-bod commented on PR #3227:
URL: https://github.com/apache/hive/pull/3227#issuecomment-1106125965

   @nrg4878 can you please review this? You might have a better context why this flag is set to true. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] wecharyu commented on pull request #3227: HIVE-26159: Make hive cli available from hive shell command

Posted by GitBox <gi...@apache.org>.
wecharyu commented on PR #3227:
URL: https://github.com/apache/hive/pull/3227#issuecomment-1108544251

   @pvary thanks for your information, my concern is that Beeline connects to hiveserver2 rather than metastore, what if I just start metastore service for test?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] wecharyu commented on pull request #3227: HIVE-26159: Make hive cli available from hive shell command

Posted by GitBox <gi...@apache.org>.
wecharyu commented on PR #3227:
URL: https://github.com/apache/hive/pull/3227#issuecomment-1109220423

   @nrg4878 I just use cli for some basic ddl and dml tests, cannot determine if all operations work fine in cli.
   
   To retain current behavior,  can we change the default service of hive shell to beeline?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] github-actions[bot] commented on pull request #3227: HIVE-26159: Make hive cli available from hive shell command

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #3227:
URL: https://github.com/apache/hive/pull/3227#issuecomment-1166385717

   This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
   Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] pvary commented on pull request #3227: HIVE-26159: Make hive cli available from hive shell command

Posted by GitBox <gi...@apache.org>.
pvary commented on PR #3227:
URL: https://github.com/apache/hive/pull/3227#issuecomment-1108607796

   @wecharyu: There was some code to start the HiveServer2 inside of the BeeLine process when it is started in CLI mode.
   I am not sure that part survived though, so it would be important to check.
   
   Thanks,
   Peter


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] nrg4878 commented on pull request #3227: HIVE-26159: Make hive cli available from hive shell command

Posted by GitBox <gi...@apache.org>.
nrg4878 commented on PR #3227:
URL: https://github.com/apache/hive/pull/3227#issuecomment-1108675056

   @wecharyu The CLI code is not being maintained in the newer code base. I do not know what functionality works and what doesnt. How much testing have you done with the fat client?
   Also with this proposed change, how can users retain current behaviour (of using beeline)? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] pvary commented on pull request #3227: HIVE-26159: Make hive cli available from hive shell command

Posted by GitBox <gi...@apache.org>.
pvary commented on PR #3227:
URL: https://github.com/apache/hive/pull/3227#issuecomment-1108437630

   @wecharyu: Retriggered the tests so we can have a green run.
   OTOH, I seem to remember that there were plans to use BeeLine, and embedded driver instead of the CLI
   
   Have you tried to issue the same commands from the BeeLine prompt as you have done with the CLI? If everything works as expected then it should work more-or-less the same way as with the CLI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org