You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/13 12:34:01 UTC

[GitHub] [arrow] paleolimbot opened a new pull request #11936: ARROW-15049: [R] arrowExports.cpp generation changed with glue package 1.5.1

paleolimbot opened a new pull request #11936:
URL: https://github.com/apache/arrow/pull/11936


   This PR fixes the code that creates arrowExports.cpp so that a regression in glue 1.5.1 does not cause massive diffs whenever somebody runs the configure script with `ARROW_R_DEV=true`. I'll also file an issue with glue since this is probably not intended behaviour; however, it's a small fix to make it work with both versions and will probably save some PR headache since a new release might not occur immediately.
   
   How I tested this:
   
   ```r
   # this
   remotes::install_github("cran/glue@1.5.1")
   Sys.setenv(ARROW_R_DEV = "true")
   remotes::install_github("paleolimbot/arrow/r@r-codegen")
   # ...nor this
   remotes::install_github("cran/glue@1.5.0")
   Sys.setenv(ARROW_R_DEV = "true")
   remotes::install_github("paleolimbot/arrow/r@r-codegen")
   # ...should cause any diffs in arrowExports.cpp
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #11936: ARROW-15049: [R] arrowExports.cpp generation changed with glue package 1.5.1

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11936:
URL: https://github.com/apache/arrow/pull/11936#issuecomment-992882423


   Benchmark runs are scheduled for baseline = 6b31026670755ba65a5385aaac312e53f5bcfac6 and contender = 7f064e4c8017dfcaa9f0f8bb96883f4f3709650a. 7f064e4c8017dfcaa9f0f8bb96883f4f3709650a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/679b0ed0a73e4c679932305e2c027559...739c8ae797ff4880bbbf0e176c4c97b9/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/00e9c86b325942abb65742b8002f603b...30e27997401c4c8cad0f7192e88054f8/)
   [Finished :arrow_down:0.09% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/3b62183a54994cd88d18a05e4abf79ce...76f25469dba54aacbd4626bb455cc89c/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #11936: ARROW-15049: [R] arrowExports.cpp generation changed with glue package 1.5.1

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11936:
URL: https://github.com/apache/arrow/pull/11936#issuecomment-992882423


   Benchmark runs are scheduled for baseline = 6b31026670755ba65a5385aaac312e53f5bcfac6 and contender = 7f064e4c8017dfcaa9f0f8bb96883f4f3709650a. 7f064e4c8017dfcaa9f0f8bb96883f4f3709650a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/679b0ed0a73e4c679932305e2c027559...739c8ae797ff4880bbbf0e176c4c97b9/)
   [Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/00e9c86b325942abb65742b8002f603b...30e27997401c4c8cad0f7192e88054f8/)
   [Finished :arrow_down:0.09% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/3b62183a54994cd88d18a05e4abf79ce...76f25469dba54aacbd4626bb455cc89c/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #11936: ARROW-15049: [R] arrowExports.cpp generation changed with glue package 1.5.1

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11936:
URL: https://github.com/apache/arrow/pull/11936#issuecomment-992433937






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jonkeane closed pull request #11936: ARROW-15049: [R] arrowExports.cpp generation changed with glue package 1.5.1

Posted by GitBox <gi...@apache.org>.
jonkeane closed pull request #11936:
URL: https://github.com/apache/arrow/pull/11936


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #11936: ARROW-15049: [R] arrowExports.cpp generation changed with glue package 1.5.1

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11936:
URL: https://github.com/apache/arrow/pull/11936#issuecomment-992882423


   Benchmark runs are scheduled for baseline = 6b31026670755ba65a5385aaac312e53f5bcfac6 and contender = 7f064e4c8017dfcaa9f0f8bb96883f4f3709650a. 7f064e4c8017dfcaa9f0f8bb96883f4f3709650a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/679b0ed0a73e4c679932305e2c027559...739c8ae797ff4880bbbf0e176c4c97b9/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/00e9c86b325942abb65742b8002f603b...30e27997401c4c8cad0f7192e88054f8/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/3b62183a54994cd88d18a05e4abf79ce...76f25469dba54aacbd4626bb455cc89c/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot commented on pull request #11936: ARROW-15049: [R] arrowExports.cpp generation changed with glue package 1.5.1

Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #11936:
URL: https://github.com/apache/arrow/pull/11936#issuecomment-992882423


   Benchmark runs are scheduled for baseline = 6b31026670755ba65a5385aaac312e53f5bcfac6 and contender = 7f064e4c8017dfcaa9f0f8bb96883f4f3709650a. 7f064e4c8017dfcaa9f0f8bb96883f4f3709650a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/679b0ed0a73e4c679932305e2c027559...739c8ae797ff4880bbbf0e176c4c97b9/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/00e9c86b325942abb65742b8002f603b...30e27997401c4c8cad0f7192e88054f8/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/3b62183a54994cd88d18a05e4abf79ce...76f25469dba54aacbd4626bb455cc89c/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org