[GitHub] [doris] adonis0147 commented on a diff in pull request #15889: [Fix](file system) Make the constructor of `XxxFileSystem` a private method

[GitBox <gi...@apache.org>]

adonis0147 commented on code in PR #15889:
URL: https://github.com/apache/doris/pull/15889#discussion_r1068867778


##########
be/src/io/fs/hdfs_file_system.cpp:
##########
@@ -61,6 +61,11 @@ class HdfsFileSystemCache {
     void _clean_oldest();
 };
 
+std::shared_ptr<HdfsFileSystem> HdfsFileSystem::create(const THdfsParams& hdfs_params,
+                                                       const std::string& path) {

Review Comment:
   It is better to change the interface like this.
   
   ```suggestion
   std::unique_ptr<HdfsFileSystem> HdfsFileSystem::create(const THdfsParams& hdfs_params,
                                                          const std::string& path) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org