[GitHub] [airflow] mik-laj commented on a change in pull request #12619: Fix webserver ingress annotations

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #12619:
URL: https://github.com/apache/airflow/pull/12619#discussion_r530967061



##########
File path: chart/tests/helm_template_generator.py
##########
@@ -29,7 +29,7 @@
 
 api_client = ApiClient()
 
-BASE_URL_SPEC = "https://raw.githubusercontent.com/instrumenta/kubernetes-json-schema/master/v1.12.9"

Review comment:
       In that case, we also need to update README.md.
   https://github.com/apache/airflow/tree/master/chart#prerequisites
   This works for me as these versions are no longer supported by GCP, Azure, AWS, so we can raise the version requirements.
   ```
   $ gcloud container get-server-config --zone us-central1-a
   Fetching server config for us-central1-a
   channels:
   - channel: RAPID
     defaultVersion: 1.18.10-gke.1500
     validVersions:
     - 1.18.10-gke.2101
     - 1.18.10-gke.1500
   - channel: REGULAR
     defaultVersion: 1.17.12-gke.1504
     validVersions:
     - 1.17.13-gke.1400
     - 1.17.12-gke.1504
   - channel: STABLE
     defaultVersion: 1.16.13-gke.404
     validVersions:
     - 1.16.15-gke.4300
     - 1.16.13-gke.404
     - 1.16.13-gke.401
     - 1.15.12-gke.6001
     - 1.15.12-gke.20
   ```
   https://docs.microsoft.com/pl-pl/azure/aks/supported-kubernetes-versions#aks-kubernetes-release-calendar
   https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org