[GitHub] [spark] MaxGekk commented on a change in pull request #26864: [SPARK-30236][SQL][DOCS] Clarify date and time patterns supported in docs

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #26864: [SPARK-30236][SQL][DOCS] Clarify date and time patterns supported in docs
URL: https://github.com/apache/spark/pull/26864#discussion_r357545162
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
 ##########
 @@ -595,7 +595,10 @@ case class WeekOfYear(child: Expression) extends UnaryExpression with ImplicitCa
 
 // scalastyle:off line.size.limit
 @ExpressionDescription(
-  usage = "_FUNC_(timestamp, fmt) - Converts `timestamp` to a value of string in the format specified by the date format `fmt`.",
+  usage = """
+    _FUNC_(timestamp, fmt) - Converts `timestamp` to a value of string in the format specified by the date format `fmt`.
+    See `java.time.format.DateTimeFormatter` for valid date and time format patterns.
 
 Review comment:
   I think it makes sense to describe `arguments`, see https://github.com/apache/spark/blob/df8aa7ba8a99cbc172f09155cbf98157fbfdf323/sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ExpressionDescription.java#L54-L60

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org