You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2019/03/08 05:54:04 UTC
[kudu-CR] KUDU-2711 (part 3). Only send one TSInfoPB per server in GetTableLocations
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12615 )
Change subject: KUDU-2711 (part 3). Only send one TSInfoPB per server in GetTableLocations
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12615/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12615/1//COMMIT_MSG@12
PS1, Line 12: In the
: worst case, this may slightly regress performance if the number of
: replicas in the response is much fewer than the number of TS in the
: cluster, since there is some extra overhead of building the index
: mapping.
> Would it be possible to quantify this?
I suppose we could run the GetTableLocations benchmark with a table where there is only one tablet and see if the extra allocation shows up in the results.
http://gerrit.cloudera.org:8080/#/c/12615/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java:
http://gerrit.cloudera.org:8080/#/c/12615/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@2123
PS1, Line 2123: // TODO(todd): handle "interned" response here
Will, since you said you were interested in taking this on, I think it'd be fine to handle this TODO in a follow-up patch. ie just address for C++ client in this patch to keep it small
--
To view, visit http://gerrit.cloudera.org:8080/12615
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief65d0825e919f681b7ade6a856c103201f8305c
Gerrit-Change-Number: 12615
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 08 Mar 2019 05:54:04 +0000
Gerrit-HasComments: Yes