You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by cm...@apache.org on 2010/11/15 18:59:40 UTC
svn commit: r1035375 - /subversion/trunk/configure.ac
Author: cmpilato
Date: Mon Nov 15 17:59:39 2010
New Revision: 1035375
URL: http://svn.apache.org/viewvc?rev=1035375&view=rev
Log:
For issue #3301 ("Cannot build without OpenSSL"), add some (hopefully)
helpful info to 'configure --help' output.
* configure.ac
Add --help information about the --with-openssl parameter, which
(like --with-ssl) isn't used by Subversion itself, but by a
dependent library (Serf, in this case). Also note the alternatives
available (Serf for Neon, and vice-versa).
Modified:
subversion/trunk/configure.ac
Modified: subversion/trunk/configure.ac
URL: http://svn.apache.org/viewvc/subversion/trunk/configure.ac?rev=1035375&r1=1035374&r2=1035375&view=diff
==============================================================================
--- subversion/trunk/configure.ac (original)
+++ subversion/trunk/configure.ac Mon Nov 15 17:59:39 2010
@@ -777,12 +777,29 @@ dnl Process some configuration options -
AC_ARG_WITH(ssl,
AS_HELP_STRING([--with-ssl],
[This option does NOT affect the Subversion build process in any
- way. It enables OpenSSL support in the Neon library. If and
- only if you are building Neon as an integrated part of the
- Subversion build process, rather than linking to an already
- installed version of Neon, you probably want to pass this
- option so that Neon (and so indirectly, Subversion) will be
- capable of https:// access.]),
+ way. It enables OpenSSL support in the Neon HTTP client
+ library. If and only if you are building Neon as an integrated
+ part of the Subversion build process, rather than linking to
+ an already installed version of Neon, you probably want to pass
+ this option so that Neon (and so indirectly, Subversion) will
+ be capable of https:// access via that library. (Note that
+ Subversion also may also or alternatively be configured to use
+ the Serf library for http:// and https:// access; see the
+ --with-serf and --with-openssl options.)])
+[])
+
+AC_ARG_WITH(openssl,
+AS_HELP_STRING([--with-openssl],
+ [This option does NOT affect the Subversion build process in any
+ way. It enables OpenSSL support in the Serf HTTP client
+ library. If and only if you are building Serf as an integrated
+ part of the Subversion build process, rather than linking to
+ an already installed version of Serf, you probably want to pass
+ this option so that Serf (and so indirectly, Subversion) will
+ be capable of https:// access via that library. (Note that
+ Subversion also may also or alternatively be configured to use
+ the Neon library for http:// and https:// access; see the
+ --with-neon and --with-ssl options.)])
[])
AC_ARG_ENABLE(debug,
Re: --with-ssl, --with-openssl - svn commit: r1035375 -
/subversion/trunk/configure.ac
Posted by Julian Foad <ju...@wandisco.com>.
On Mon, 2010-11-15 at 17:59 +0000, cmpilato@apache.org wrote:
> Author: cmpilato
> Date: Mon Nov 15 17:59:39 2010
> New Revision: 1035375
>
> URL: http://svn.apache.org/viewvc?rev=1035375&view=rev
> Log:
> For issue #3301 ("Cannot build without OpenSSL"),
<http://subversion.tigris.org/issues/show_bug.cgi?id=3301>
> add some (hopefully)
> helpful info to 'configure --help' output.
>
> * configure.ac
> Add --help information about the --with-openssl parameter, which
> (like --with-ssl) isn't used by Subversion itself, but by a
> dependent library (Serf, in this case). Also note the alternatives
> available (Serf for Neon, and vice-versa).
Based on my understanding from this help text, I think we should rename
those options to something like
--with-neon-openssl
--with-serf-openssl
and deprecate the old names
--with-openssl
--with-ssl
Did I get them the right way around? Ah, no - other way around. That's
my point, you see :-)
Makes sense?
- Julian