[jira] [Updated] (DERBY-6709) Convert the storetests suite to JUnit

["Knut Anders Hatlen (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DERBY-6709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen updated DERBY-6709:
--------------------------------------

    Attachment: d6709-1a.diff

The attached patch [^d6709-1a.diff] converts the tests in the
storetests suite to JUnit, adds them to suites.All and removes them
from derbyall.

storetests/st_schema.sql was removed and not converted, since it was
just an empty SQL script. As far as I could tell, its only purpose was
to make sure the database was created before the other tests in the
suite ran. (The suite was configured to reuse the database in all the
tests. Presumably for performance reasons only, since none of the
tests depended on data created by the previous test.)

The patch removes the following files:

- java/testing/org/apache/derbyTesting/functionTests/master/derby94.out
- java/testing/org/apache/derbyTesting/functionTests/master/st_derby1939.out
- java/testing/org/apache/derbyTesting/functionTests/master/st_derby715.out
- java/testing/org/apache/derbyTesting/functionTests/master/st_reclaim_longcol.out
- java/testing/org/apache/derbyTesting/functionTests/master/st_schema.out
- java/testing/org/apache/derbyTesting/functionTests/suites/storetests.properties
- java/testing/org/apache/derbyTesting/functionTests/suites/storetests.runall
- java/testing/org/apache/derbyTesting/functionTests/tests/storetests/default_app.properties
- java/testing/org/apache/derbyTesting/functionTests/tests/storetests/default_derby.properties
- java/testing/org/apache/derbyTesting/functionTests/tests/storetests/derby94.sql
- java/testing/org/apache/derbyTesting/functionTests/tests/storetests/derby94_app.properties
- java/testing/org/apache/derbyTesting/functionTests/tests/storetests/derby94_derby.properties
- java/testing/org/apache/derbyTesting/functionTests/tests/storetests/st_derby715_derby.properties
- java/testing/org/apache/derbyTesting/functionTests/tests/storetests/st_derby715_sed.properties
- java/testing/org/apache/derbyTesting/functionTests/tests/storetests/st_schema.sql
- java/testing/org/apache/derbyTesting/functionTests/tests/storetests/st_schema_app.properties

The following files are added:

- java/testing/org/apache/derbyTesting/functionTests/tests/storetests/_Suite.java (new suite that contains all the converted tests)
- java/testing/org/apache/derbyTesting/functionTests/tests/storetests/Derby94Test.java (replaces storetests/derby94.sql)

The following files are modified:

- java/testing/org/apache/derbyTesting/functionTests/suites/AllPackages.java (add the new suite to suites.All)
- java/testing/org/apache/derbyTesting/functionTests/suites/storeall.properties (remove reference to old suite)
- java/testing/org/apache/derbyTesting/functionTests/suites/storemats.properties (remove reference to old suite)
- java/testing/org/apache/derbyTesting/functionTests/suites/storeunit.properties (remove reference to old suite)
- java/testing/org/apache/derbyTesting/functionTests/tests/storetests/build.xml (add junit.jar to compile classpath)
- java/testing/org/apache/derbyTesting/functionTests/tests/storetests/st_derby1939.java (converted from old harness test to JUnit)
- java/testing/org/apache/derbyTesting/functionTests/tests/storetests/st_derby715.java (converted from old harness test to JUnit)
- java/testing/org/apache/derbyTesting/functionTests/tests/storetests/st_reclaim_longcol.java (converted from old harness test to JUnit)



> Convert the storetests suite to JUnit
> -------------------------------------
>
>                 Key: DERBY-6709
>                 URL: https://issues.apache.org/jira/browse/DERBY-6709
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: d6709-1a.diff
>
>
> The storetests suite is a small test suite that consists of the following tests:
> storetests/st_schema.sql
> storetests/st_derby1939.java
> storetests/st_reclaim_longcol.java
> storetests/st_derby715.java
> storetests/derby94.sql
> It looks like these tests could be converted to JUnit relatively easily.



--
This message was sent by Atlassian JIRA
(v6.2#6252)