You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by ha...@apache.org on 2016/04/11 00:48:33 UTC
[22/49] git commit: [flex-asjs] [refs/heads/develop] - Fixed concat()
to modify the original XMLList
Fixed concat() to modify the original XMLList
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/7f23ef37
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/7f23ef37
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/7f23ef37
Branch: refs/heads/develop
Commit: 7f23ef37d99f871598f9cdc311615f1e56dcf97f
Parents: a487152
Author: Harbs <ha...@in-tools.com>
Authored: Thu Feb 11 14:08:27 2016 +0200
Committer: Harbs <ha...@in-tools.com>
Committed: Thu Feb 11 14:08:27 2016 +0200
----------------------------------------------------------------------
frameworks/projects/XML/src/main/flex/XML.as | 2 +-
.../projects/XML/src/main/flex/XMLList.as | 21 ++++++++++----------
2 files changed, 11 insertions(+), 12 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/7f23ef37/frameworks/projects/XML/src/main/flex/XML.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/XML/src/main/flex/XML.as b/frameworks/projects/XML/src/main/flex/XML.as
index 69d94b5..8c65385 100644
--- a/frameworks/projects/XML/src/main/flex/XML.as
+++ b/frameworks/projects/XML/src/main/flex/XML.as
@@ -739,7 +739,7 @@ package
if(name.matches(_children[i].name()))
list.appendChild(_children[i]);
- list = list.concat(_children[i].descendants());
+ list.concat(_children[i].descendants());
}
}
}
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/7f23ef37/frameworks/projects/XML/src/main/flex/XMLList.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/XML/src/main/flex/XMLList.as b/frameworks/projects/XML/src/main/flex/XMLList.as
index e34b765..2ad96ce 100644
--- a/frameworks/projects/XML/src/main/flex/XMLList.as
+++ b/frameworks/projects/XML/src/main/flex/XMLList.as
@@ -176,7 +176,7 @@ package
{
var list:XMLList = _xmlArray[i].attribute(attributeName);
if(list.length())
- retVal = retVal.concat(list);
+ retVal.concat(list);
}
return retVal;
}
@@ -194,7 +194,7 @@ package
{
var list:XMLList = _xmlArray[i].attributes();
if(list.length())
- retVal = retVal.concat(list);
+ retVal.concat(list);
}
return retVal;
}
@@ -213,7 +213,7 @@ package
{
var list:XMLList = _xmlArray[i].child(propertyName);
if(list.length())
- retVal = retVal.concat(list);
+ retVal.concat(list);
}
return retVal;
}
@@ -231,7 +231,7 @@ package
{
var list:XMLList = _xmlArray[i].children();
if(list.length)
- retVal = retVal.concat(list);
+ retVal.concat(list);
}
return retVal;
}
@@ -249,7 +249,7 @@ package
{
var list:XMLList = _xmlArray[i].comments();
if(list.length)
- retVal = retVal.concat(list);
+ retVal.concat(list);
}
return retVal;
}
@@ -265,12 +265,11 @@ package
if(!(list is XMLList))
throw new TypeError("invalid type");
- var retVal:XMLList = this.copy();
var item:XML;
for each(item in list)
- retVal.appendChild(item);
+ appendChild(item);
- return retVal;
+ return this;
}
/**
@@ -303,7 +302,7 @@ package
var retVal:XMLList = new XMLList();
var len:int = _xmlArray.length;
for (var i:int=0;i<len;i++)
- retVal[i] = _xmlArray[i].copy();
+ retVal.appendChild(_xmlArray[i].copy());
return retVal;
}
@@ -323,7 +322,7 @@ package
{
var list:XMLList = _xmlArray[i].descendants(name);
if(list.length())
- retVal = retVal.concat(list);
+ retVal.concat(list);
}
return retVal;
}
@@ -343,7 +342,7 @@ package
{
var list:XMLList = _xmlArray[i].elements(name);
if(list.length())
- retVal = retVal.concat(list);
+ retVal.concat(list);
}
return retVal;
}