svn commit: r1125415 - in /subversion/trunk/subversion/libsvn_ra_neon: ra_neon.h session.c util.c

[iv...@apache.org]

Author: ivan
Date: Fri May 20 14:29:12 2011
New Revision: 1125415

URL: http://svn.apache.org/viewvc?rev=1125415&view=rev
Log:
Follow-up to r1125391: Use svn_tristate_t instead of hardcoded values.

Suggested by: gstein

* subversion/libsvn_ra_neon/ra_neon.h
  (svn_ra_neon__session_t): Change type of supports_deadprop_count to 
   svn_tristate_t.

* subversion/libsvn_ra_neon/session.c
  (svn_ra_neon__open): Initialize supports_deadprop_count to 
   svn_tristate_unknown.

* subversion/libsvn_ra_neon/util.c
  (svn_ra_neon__get_deadprop_count_support): Update.
  

Modified:
    subversion/trunk/subversion/libsvn_ra_neon/ra_neon.h
    subversion/trunk/subversion/libsvn_ra_neon/session.c
    subversion/trunk/subversion/libsvn_ra_neon/util.c

Modified: subversion/trunk/subversion/libsvn_ra_neon/ra_neon.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_neon/ra_neon.h?rev=1125415&r1=1125414&r2=1125415&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_neon/ra_neon.h (original)
+++ subversion/trunk/subversion/libsvn_ra_neon/ra_neon.h Fri May 20 14:29:12 2011
@@ -128,10 +128,8 @@ typedef struct svn_ra_neon__session_t {
   apr_hash_t *capabilities;
 
   /* Tri-state variable holding information about server support for
-     deadprop-count property. Zero if information still unknown,
-     positive if server support deadprop-count and negative if it
-     does not. */
-  int supports_deadprop_count;
+     deadprop-count property.*/
+  svn_tristate_t supports_deadprop_count;
 
   /*** HTTP v2 protocol stuff. ***
    *

Modified: subversion/trunk/subversion/libsvn_ra_neon/session.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_neon/session.c?rev=1125415&r1=1125414&r2=1125415&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_neon/session.c (original)
+++ subversion/trunk/subversion/libsvn_ra_neon/session.c Fri May 20 14:29:12 2011
@@ -950,7 +950,7 @@ svn_ra_neon__open(svn_ra_session_t *sess
   ras->progress_baton = callbacks->progress_baton;
   ras->progress_func = callbacks->progress_func;
   ras->capabilities = apr_hash_make(ras->pool);
-  ras->supports_deadprop_count = 0;
+  ras->supports_deadprop_count = svn_tristate_unknown;
   ras->vcc = NULL;
   ras->uuid = NULL;
   /* save config and server group in the auth parameter hash */

Modified: subversion/trunk/subversion/libsvn_ra_neon/util.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_neon/util.c?rev=1125415&r1=1125414&r2=1125415&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_neon/util.c (original)
+++ subversion/trunk/subversion/libsvn_ra_neon/util.c Fri May 20 14:29:12 2011
@@ -1623,7 +1623,7 @@ svn_ra_neon__get_deadprop_count_support(
     }
 
   /* Check if we already checked deadprop_count support. */
-  if (!ras->supports_deadprop_count)
+  if (ras->supports_deadprop_count == svn_tristate_unknown)
     {
       svn_ra_neon__resource_t *rsrc;
       const svn_string_t *deadprop_count;
@@ -1636,15 +1636,15 @@ svn_ra_neon__get_deadprop_count_support(
                                     APR_HASH_KEY_STRING);
       if (deadprop_count != NULL)
         {
-          ras->supports_deadprop_count = 1;
+          ras->supports_deadprop_count = svn_tristate_true;
         }
       else
         {
-          ras->supports_deadprop_count = -1;
+          ras->supports_deadprop_count = svn_tristate_false;
         }
     }
 
-  *supported = (ras->supports_deadprop_count > 0);
+  *supported = (ras->supports_deadprop_count == svn_tristate_true);
 
   return SVN_NO_ERROR;
 }