You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/19 08:54:01 UTC
[GitHub] [cloudstack] sureshanaparti opened a new pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
sureshanaparti opened a new pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304
## Description
<!--- Describe your changes in detail -->
Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
- Added support for PowerFlex/ScaleIO (v3.5 onwards) storage pool as a primary storage in CloudStack (for KVM hypervisor) and enabled VM/Volume operations on that pool (using pool tag).
Please find more details in the FS here:
https://cwiki.apache.org/confluence/x/cDl4CQ
Documentation PR: https://github.com/apache/cloudstack-documentation/pull/169
Primate UI: https://github.com/apache/cloudstack-primate/pull/863
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
Manual tests:
- Deploy VM, with qcow2/raw images (with data disk)
- Stop / Start / Restart / Reinstall / Destroy VM(s)
- Attach / Detach / Resize / Destroy disk(s)
- Create/Revert/Delete volume snapshots (on primary storage)
- Create / Delete VM Snapshots (for Running & Stopped VMs)
- Revert VM Snapshots (Stopped VMs)
- Create template from Volume / Snapshot in ScaleIO pool and Deploy VM using that template
- Migrate VM (with PowerFlex volumes) within/across Clusters
- Migrate Volume (Volume Tree or V-Tree, along with snapshots) to other PowerFlex pool on the same PowerFlex/ScaleIO cluster
- Migrate Volume (with no snapshots) to other PowerFlex pool on different PowerFlex/ScaleIO cluster
Marvin tests:
=== TestName: test_01_create_vm_with_volume | Status : SUCCESS ===
=== TestName: test_02_attach_new_volume_to_stopped_vm | Status : SUCCESS ===
=== TestName: test_03_attach_detach_attach_volume_to_vm | Status : SUCCESS ===
=== TestName: test_04_detach_vol_stopped_vm_start | Status : SUCCESS ===
=== TestName: test_05_attach_volume_to_stopped_vm | Status : SUCCESS ===
=== TestName: test_06_attached_volume_reboot_vm | Status : SUCCESS ===
=== TestName: test_07_detach_volume_reboot_vm | Status : SUCCESS ===
=== TestName: test_08_delete_volume_was_attached | Status : SUCCESS ===
=== TestName: test_09_migrate_volume_to_same_instance_pool | Status : SUCCESS ===
=== TestName: test_10_migrate_volume_to_distinct_instance_pool | Status : SUCCESS ===
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-781485797
Packaging result: ✖centos7 ✔centos8 ✔debian. JID-2742
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#discussion_r526017722
##########
File path: ui/scripts/instances.js
##########
@@ -4189,6 +4189,10 @@
allowedActions.push("storageSnapshot");
}
+ if (jsonObj.hypervisor == 'KVM' && jsonObj.pooltype == 'PowerFlex') {
+ allowedActions.push("snapshot");
+ }
+
Review comment:
> @sureshanaparti do we need a Primate change for this or is it already handled there?
@shwstppr Updated this change in primate. PR: https://github.com/apache/cloudstack-primate/pull/863.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-709661695
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2190
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-771639727
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-709754228
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-771670297
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2638
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-781523109
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2743
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-758663282
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-720656707
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-773183135
> test_04_change_offering_small Error 4.29 test_service_offerings.py
> This could turn out a bug or limitation, we haven't seen it elsewhere I believe.
Observed error (errorText:VM current state is : PowerOn. But VM should be in PowerOff state.) in test "test_04_change_offering_small" - VM is stopped, and followed by triggering _changeServiceForVirtualMachine_ API. Updated test to confirm the VM 'Stopped' state and trigger the _changeServiceForVirtualMachine_ API.
This above test failure/error is not related to the changes in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-771673058
@blueorangutan test matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-689486102
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-781523752
@blueorangutan test matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-773074147
@sureshanaparti can you check the consistently failing vmware issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-719059785
<b>Trillian test result (tid-3105)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31860 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4304-t3105-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-709650741
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-771673894
@rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-776456643
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2669
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-773654847
<b>Trillian test result (tid-3489)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45153 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4304-t3489-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Smoke tests completed. 83 look OK, 3 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 802.71 | test_kubernetes_clusters.py
test_04_change_offering_small | `Error` | 5.20 | test_service_offerings.py
test_change_service_offering_for_vm_with_snapshots | `Error` | 141.65 | test_vm_snapshots.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-773072097
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-712688499
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-732012313
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-689501651
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1930
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-689477286
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1929
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-776434315
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#discussion_r524261256
##########
File path: engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
##########
@@ -574,6 +574,14 @@ private void handleVolumeMigrationFromManagedStorageToNonManagedStorage(VolumeIn
}
}
+ private void verifyFormatWithPoolType(ImageFormat imageFormat, StoragePoolType poolType) {
+ if (imageFormat != ImageFormat.VHD && imageFormat != ImageFormat.OVA && imageFormat != ImageFormat.QCOW2 &&
+ !(imageFormat == ImageFormat.RAW && StoragePoolType.PowerFlex == poolType)) {
+ throw new CloudRuntimeException("Only the following image types are currently supported: " +
+ ImageFormat.VHD.toString() + ", " + ImageFormat.OVA.toString() + ", " + ImageFormat.QCOW2.toString() + ", and " + ImageFormat.RAW.toString() + "(for PowerFlex)");
Review comment:
> Is this message in-line with the fact that we support PowerFlex only for KVM right now?
yes, in-line with the RAW disk support with PowerFlex storage, for KVM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-731995214
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2422
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-712708810
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2211
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-758651669
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2535
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-778292604
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-709752814
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-776434493
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-771556087
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-771640395
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-745406936
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-758651669
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2535
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-762482542
<b>Trillian test result (tid-3387)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40328 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4304-t3387-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 840.87 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 138.01 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-779227445
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-758645689
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-718719616
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-772639107
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-773176841
@blueorangutan test centos7 vmware-67u3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-689485832
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#discussion_r524262830
##########
File path: engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
##########
@@ -2301,7 +2325,9 @@ private void handleCreateTemplateFromManagedVolume(VolumeInfo volumeInfo, Templa
CopyCmdAnswer copyCmdAnswer = null;
try {
- if (!ImageFormat.QCOW2.equals(volumeInfo.getFormat())) {
+ StoragePoolVO storagePoolVO = _storagePoolDao.findById(volumeInfo.getPoolId());
+
+ if (!ImageFormat.QCOW2.equals(volumeInfo.getFormat()) && !(ImageFormat.RAW.equals(volumeInfo.getFormat()) && StoragePoolType.PowerFlex == storagePoolVO.getPoolType())) {
Review comment:
> We listed couple of more image formats with powerflex support
RAW format is the only supported disk format with PowerFlex storage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-718737196
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2308
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-771556087
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-770637661
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-776459126
@blueorangutan test centos7 vmware-67u3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-773176841
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-779247298
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2710
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-731979807
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-773074147
@sureshanaparti can you check the consistently failing vmware issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-772190793
<b>Trillian test result (tid-3476)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44275 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4304-t3476-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 168.68 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-781453461
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-772214336
<b>Trillian test result (tid-3477)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48132 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4304-t3477-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Smoke tests completed. 84 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 827.96 | test_kubernetes_clusters.py
test_04_change_offering_small | `Error` | 5.18 | test_service_offerings.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on a change in pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on a change in pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#discussion_r573580121
##########
File path: test/integration/plugins/scaleio/test_scaleio_volumes.py
##########
@@ -0,0 +1,1213 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import logging
+import random
+import time
+
+# All tests inherit from cloudstackTestCase
+from marvin.cloudstackTestCase import cloudstackTestCase
+
+# Import Integration Libraries
+# base - contains all resources as entities and defines create, delete, list operations on them
+from marvin.lib.base import Account, DiskOffering, ServiceOffering, Snapshot, StoragePool, Template, User, VirtualMachine, Volume
+
+# common - commonly used methods for all tests are listed here
+from marvin.lib.common import get_domain, get_template, get_zone, list_clusters, list_hosts, list_virtual_machines, \
+ list_volumes
+
+# utils - utility classes for common cleanup, external library wrappers, etc.
+from marvin.lib.utils import cleanup_resources, validateList
+from marvin.codes import PASS
+from nose.plugins.attrib import attr
+
+# Prerequisites:
+# Only one zone
+# Only one pod
+# Only one cluster
+#
+# One PowerFlex/ScaleIO storage pool for basic tests
+# Only KVM hypervisor is supported for PowerFlex/ScaleIO storage pool
+# KVM host(s) with ScaleIO Data Client (SDC) installed and connected to Metadata Manager (MDM)
+#
+# For volume migration tests, additional storage pool(s) are required
+# One PowerFlex/ScaleIO storage pool on the same ScaleIO storage cluster/instance
+# One PowerFlex/ScaleIO storage pool on different ScaleIO storage cluster/instance
+#
+
+class TestData():
+ # constants
+ account = "account"
+ clusterId = "clusterId"
+ computeOffering = "computeoffering"
+ diskName = "diskname"
+ diskOffering = "diskoffering"
+ diskOfferingSameInstance = "diskOfferingSameInstance"
+ diskOfferingDistinctInstance = "diskOfferingDistinctInstance"
+ domainId = "domainId"
+ hypervisor = "hypervisor"
+ kvm = "kvm"
+ login = "login"
+ gatewayip = "gatewayip"
+ one_GB_in_bytes = 1073741824
+ password = "password"
+ port = "port"
+ primaryStorage = "primarystorage"
+ primaryStorageSameInstance = "primaryStorageSameInstance"
+ primaryStorageDistinctInstance = "primaryStorageDistinctInstance"
+ provider = "provider"
+ scope = "scope"
+ powerFlex = "powerflex"
+ storageTag = "pflex"
+ storageTagSameInstance = "pflexsame"
+ storageTagDistinctInstance = "pflexdiff"
+ tags = "tags"
+ templateCacheNameKvm = "centos55-x86-64"
+ testAccount = "testaccount"
+ url = "url"
+ user = "user"
+ username = "username"
+ virtualMachine = "virtualmachine"
+ virtualMachine2 = "virtualmachine2"
+ virtualMachine3 = "virtualmachine3"
+ virtualMachine4 = "virtualmachine4"
+ volume_1 = "volume_1"
+ volume_2 = "volume_2"
+ volume_3 = "volume_3"
+ volume_4 = "volume_4"
+ kvm = "kvm"
+ zoneId = "zoneId"
+ migrationTests = "migrationTests"
+
+ # hypervisor type to test
+ hypervisor_type = kvm
+
+ def __init__(self):
+ self.testdata = {
+ TestData.kvm: {
+ TestData.username: "root",
+ TestData.password: "P@ssword123"
+ },
+ TestData.account: {
+ "email": "test1@test1.com",
+ "firstname": "John",
+ "lastname": "Doe",
+ "username": "test1",
+ "password": "test"
+ },
+ TestData.testAccount: {
+ "email": "test2@test2.com",
+ "firstname": "Jane",
+ "lastname": "Doe",
+ "username": "test2",
+ "password": "test"
+ },
+ TestData.user: {
+ "email": "user@test1.com",
+ "firstname": "Jane",
+ "lastname": "Doe",
+ "username": "test1user",
+ "password": "password"
+ },
+ TestData.primaryStorage: {
+ "name": "PowerFlexPool-%d" % random.randint(0, 100),
+ TestData.scope: "ZONE",
+ "url": "powerflex://admin:P%40ssword123@10.10.4.141/cspool01",
Review comment:
I don't see how this is going to be a reliable and stable instance of running the tests long term. If we don't have an automated method to come up with a PowerFlex instance at the moment, better make it a requirement to run the tests and leave the test unrelated to adding primary storage.
##########
File path: test/integration/plugins/scaleio/test_scaleio_volumes.py
##########
@@ -0,0 +1,1213 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import logging
+import random
+import time
+
+# All tests inherit from cloudstackTestCase
+from marvin.cloudstackTestCase import cloudstackTestCase
+
+# Import Integration Libraries
+# base - contains all resources as entities and defines create, delete, list operations on them
+from marvin.lib.base import Account, DiskOffering, ServiceOffering, Snapshot, StoragePool, Template, User, VirtualMachine, Volume
+
+# common - commonly used methods for all tests are listed here
+from marvin.lib.common import get_domain, get_template, get_zone, list_clusters, list_hosts, list_virtual_machines, \
+ list_volumes
+
+# utils - utility classes for common cleanup, external library wrappers, etc.
+from marvin.lib.utils import cleanup_resources, validateList
+from marvin.codes import PASS
+from nose.plugins.attrib import attr
+
+# Prerequisites:
+# Only one zone
+# Only one pod
+# Only one cluster
+#
+# One PowerFlex/ScaleIO storage pool for basic tests
+# Only KVM hypervisor is supported for PowerFlex/ScaleIO storage pool
+# KVM host(s) with ScaleIO Data Client (SDC) installed and connected to Metadata Manager (MDM)
+#
+# For volume migration tests, additional storage pool(s) are required
+# One PowerFlex/ScaleIO storage pool on the same ScaleIO storage cluster/instance
+# One PowerFlex/ScaleIO storage pool on different ScaleIO storage cluster/instance
+#
+
+class TestData():
+ # constants
+ account = "account"
+ clusterId = "clusterId"
+ computeOffering = "computeoffering"
+ diskName = "diskname"
+ diskOffering = "diskoffering"
+ diskOfferingSameInstance = "diskOfferingSameInstance"
+ diskOfferingDistinctInstance = "diskOfferingDistinctInstance"
+ domainId = "domainId"
+ hypervisor = "hypervisor"
+ kvm = "kvm"
+ login = "login"
+ gatewayip = "gatewayip"
+ one_GB_in_bytes = 1073741824
+ password = "password"
+ port = "port"
+ primaryStorage = "primarystorage"
+ primaryStorageSameInstance = "primaryStorageSameInstance"
+ primaryStorageDistinctInstance = "primaryStorageDistinctInstance"
+ provider = "provider"
+ scope = "scope"
+ powerFlex = "powerflex"
+ storageTag = "pflex"
+ storageTagSameInstance = "pflexsame"
+ storageTagDistinctInstance = "pflexdiff"
+ tags = "tags"
+ templateCacheNameKvm = "centos55-x86-64"
+ testAccount = "testaccount"
+ url = "url"
+ user = "user"
+ username = "username"
+ virtualMachine = "virtualmachine"
+ virtualMachine2 = "virtualmachine2"
+ virtualMachine3 = "virtualmachine3"
+ virtualMachine4 = "virtualmachine4"
+ volume_1 = "volume_1"
+ volume_2 = "volume_2"
+ volume_3 = "volume_3"
+ volume_4 = "volume_4"
+ kvm = "kvm"
+ zoneId = "zoneId"
+ migrationTests = "migrationTests"
+
+ # hypervisor type to test
+ hypervisor_type = kvm
+
+ def __init__(self):
+ self.testdata = {
+ TestData.kvm: {
+ TestData.username: "root",
+ TestData.password: "P@ssword123"
+ },
+ TestData.account: {
+ "email": "test1@test1.com",
+ "firstname": "John",
+ "lastname": "Doe",
+ "username": "test1",
+ "password": "test"
+ },
+ TestData.testAccount: {
+ "email": "test2@test2.com",
+ "firstname": "Jane",
+ "lastname": "Doe",
+ "username": "test2",
+ "password": "test"
+ },
+ TestData.user: {
+ "email": "user@test1.com",
+ "firstname": "Jane",
+ "lastname": "Doe",
+ "username": "test1user",
+ "password": "password"
+ },
+ TestData.primaryStorage: {
+ "name": "PowerFlexPool-%d" % random.randint(0, 100),
+ TestData.scope: "ZONE",
+ "url": "powerflex://admin:P%40ssword123@10.10.4.141/cspool01",
+ TestData.provider: "PowerFlex",
+ TestData.tags: TestData.storageTag + "," + TestData.storageTagSameInstance + "," + TestData.storageTagDistinctInstance,
+ TestData.hypervisor: "KVM"
+ },
+ TestData.virtualMachine: {
+ "name": "TestVM1",
+ "displayname": "Test VM 1"
+ },
+ TestData.virtualMachine2: {
+ "name": "TestVM2",
+ "displayname": "Test VM 2"
+ },
+ TestData.virtualMachine3: {
+ "name": "TestVM3",
+ "displayname": "Test VM 3"
+ },
+ TestData.virtualMachine4: {
+ "name": "TestVM4",
+ "displayname": "Test VM 4"
+ },
+ TestData.computeOffering: {
+ "name": "PowerFlex_Compute",
+ "displaytext": "PowerFlex_Compute",
+ "cpunumber": 1,
+ "cpuspeed": 500,
+ "memory": 512,
+ "storagetype": "shared",
+ TestData.tags: TestData.storageTag
+ },
+ TestData.diskOffering: {
+ "name": "PowerFlex_Disk",
+ "displaytext": "PowerFlex_Disk",
+ "disksize": 8,
+ TestData.tags: TestData.storageTag,
+ "storagetype": "shared"
+ },
+ TestData.volume_1: {
+ TestData.diskName: "test-volume-1",
+ },
+ TestData.volume_2: {
+ TestData.diskName: "test-volume-2",
+ },
+ TestData.volume_3: {
+ TestData.diskName: "test-volume-3",
+ },
+ TestData.volume_4: {
+ TestData.diskName: "test-volume-4",
+ },
+ TestData.zoneId: 1,
+ TestData.clusterId: 1,
+ TestData.domainId: 1,
+ TestData.url: "10.10.3.226",
Review comment:
Same here, leave the 'Add Storage pool' test scenario maybe...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-781932019
Tests LGTM, waiting for manual confirmation from @borisstoyanov
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti edited a comment on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti edited a comment on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-773183135
> test_04_change_offering_small Error 4.29 test_service_offerings.py
> This could turn out a bug or limitation, we haven't seen it elsewhere I believe.
Observed error (errorText:VM current state is : PowerOn. But VM should be in PowerOff state.) in test "test_04_change_offering_small" - VM is stopped, and followed by triggering _changeServiceForVirtualMachine_ API. Updated test to confirm the VM 'Stopped' state and trigger the _changeServiceForVirtualMachine_ API. and Re-triggered the smoke tests.
This above test failure/error is not related to the changes in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-781524255
@rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-724563083
@sureshanaparti can you add a small README.md for the scaleio smoketests, i.e. what needs to be (a) setup and how (say a particular storagepool name etc?, and maybe just link to https://www.dell.com/support/home/en-in/product-support/product/scaleio/docs), and (b) how to run the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-771572792
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2632
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-732012520
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-718720229
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-710135012
<b>Trillian test result (tid-2976)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39062 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4304-t2976-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 84 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_hostha_kvm_host_fencing | `Error` | 174.43 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-758695147
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2536
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-773177213
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#discussion_r521296782
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/UserVmResponse.java
##########
@@ -310,6 +310,10 @@
@Param(description = "Guest vm Boot Type")
private String bootType;
+ @SerializedName(ApiConstants.POOL_TYPE)
+ @Param(description = "the pool type of the virtual machine")
Review comment:
```suggestion
@Param(description = "the pool type of the virtual machine", since="4.16)
```
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateDiskOfferingCmd.java
##########
@@ -152,6 +156,9 @@
since = "4.14")
private String cacheMode;
+ @Parameter(name = ApiConstants.DETAILS, type = CommandType.MAP, description = "details to specify disk offering parameters")
Review comment:
will be good to add a since tag here
```suggestion
@Parameter(name = ApiConstants.DETAILS, type = CommandType.MAP, description = "details to specify disk offering parameters", since="4.16)
```
##########
File path: engine/api/src/main/java/com/cloud/vm/VirtualMachineManager.java
##########
@@ -59,7 +59,13 @@
"The default label name for the config drive", false);
ConfigKey<Boolean> VmConfigDriveOnPrimaryPool = new ConfigKey<>("Advanced", Boolean.class, "vm.configdrive.primarypool.enabled", "false",
- "If config drive need to be created and hosted on primary storage pool. Currently only supported for KVM.", true);
+ "If config drive need to be created and hosted on primary storage pool. Currently only supported for KVM.", true, ConfigKey.Scope.Zone);
Review comment:
@sureshanaparti this config is changed from global scope to zone. Will that affect the existing setup in any way?
##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
##########
@@ -1465,11 +1543,17 @@ public void prepareForMigration(VirtualMachineProfile vm, DeployDestination dest
long hostId = vm.getVirtualMachine().getHostId();
Host host = _hostDao.findById(hostId);
- volService.grantAccess(volFactory.getVolume(newVol.getId()), host, destPool);
+ try {
+ volService.grantAccess(volFactory.getVolume(newVol.getId()), host, destPool);
+ } catch (Exception e) {
+ throw new StorageAccessException("Unable to grant access to volume: " + newVol.getId() + " on host: " + host.getId());
+ }
Review comment:
Curious, why we need to catch all _Exception_ here? And we are not even logging it then
##########
File path: engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
##########
@@ -2301,7 +2325,9 @@ private void handleCreateTemplateFromManagedVolume(VolumeInfo volumeInfo, Templa
CopyCmdAnswer copyCmdAnswer = null;
try {
- if (!ImageFormat.QCOW2.equals(volumeInfo.getFormat())) {
+ StoragePoolVO storagePoolVO = _storagePoolDao.findById(volumeInfo.getPoolId());
+
+ if (!ImageFormat.QCOW2.equals(volumeInfo.getFormat()) && !(ImageFormat.RAW.equals(volumeInfo.getFormat()) && StoragePoolType.PowerFlex == storagePoolVO.getPoolType())) {
Review comment:
We listed couple of more image formats with powerflex support
##########
File path: engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
##########
@@ -574,6 +574,14 @@ private void handleVolumeMigrationFromManagedStorageToNonManagedStorage(VolumeIn
}
}
+ private void verifyFormatWithPoolType(ImageFormat imageFormat, StoragePoolType poolType) {
+ if (imageFormat != ImageFormat.VHD && imageFormat != ImageFormat.OVA && imageFormat != ImageFormat.QCOW2 &&
+ !(imageFormat == ImageFormat.RAW && StoragePoolType.PowerFlex == poolType)) {
+ throw new CloudRuntimeException("Only the following image types are currently supported: " +
+ ImageFormat.VHD.toString() + ", " + ImageFormat.OVA.toString() + ", " + ImageFormat.QCOW2.toString() + ", and " + ImageFormat.RAW.toString() + "(for PowerFlex)");
Review comment:
Is this message in-line with the fact that we support PowerFlex only for KVM right now?
##########
File path: ui/scripts/instances.js
##########
@@ -4189,6 +4189,10 @@
allowedActions.push("storageSnapshot");
}
+ if (jsonObj.hypervisor == 'KVM' && jsonObj.pooltype == 'PowerFlex') {
+ allowedActions.push("snapshot");
+ }
+
Review comment:
@sureshanaparti do we need a Primate change for this or is it already handled there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-773072097
<b>Trillian test result (tid-3484)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49485 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4304-t3484-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Smoke tests completed. 84 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_deploy_kubernetes_cluster | `Failure` | 3606.90 | test_kubernetes_clusters.py
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 202.81 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 3609.22 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.09 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.07 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 73.42 | test_kubernetes_clusters.py
test_04_change_offering_small | `Error` | 4.29 | test_service_offerings.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-781497914
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-771673058
@blueorangutan test matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-689466673
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-758662535
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-689466321
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-720657204
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-776459579
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-778313874
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2697
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-745431707
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2497
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-709651188
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on a change in pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
slavkap commented on a change in pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#discussion_r579115128
##########
File path: server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
##########
@@ -358,9 +363,33 @@ public VMSnapshot allocVMSnapshot(Long vmId, String vsDisplayName, String vsDesc
throw new InvalidParameterValueException("Can not snapshot memory when VM is not in Running state");
}
+ List<VolumeVO> rootVolumes = _volumeDao.findReadyRootVolumesByInstance(userVmVo.getId());
+ if (rootVolumes == null || rootVolumes.isEmpty()) {
+ throw new CloudRuntimeException("Unable to find root volume for the user vm:" + userVmVo.getUuid());
+ }
+
+ VolumeVO rootVolume = rootVolumes.get(0);
+ StoragePoolVO rootVolumePool = _storagePoolDao.findById(rootVolume.getPoolId());
+ if (rootVolumePool == null) {
+ throw new CloudRuntimeException("Unable to find root volume storage pool for the user vm:" + userVmVo.getUuid());
+ }
+
// for KVM, only allow snapshot with memory when VM is in running state
- if (userVmVo.getHypervisorType() == HypervisorType.KVM && userVmVo.getState() == State.Running && !snapshotMemory) {
- throw new InvalidParameterValueException("KVM VM does not allow to take a disk-only snapshot when VM is in running state");
+ if (userVmVo.getHypervisorType() == HypervisorType.KVM) {
+ if (rootVolumePool.getPoolType() != Storage.StoragePoolType.PowerFlex) {
Review comment:
Thanks, @sureshanaparti, for the reply! My bad that I didn't look below in the code, where the VMSnapshot object is created. My suggestion about this functionality was to be more general for the rest of the plugins if somebody wants to integrate with it. I will try to find a solution in our PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-758698528
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2537
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-770637136
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-772638335
@blueorangutan test centos7 vmware-67u3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-762133897
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-779226965
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-758646988
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2534
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti edited a comment on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti edited a comment on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-773183135
> test_04_change_offering_small Error 4.29 test_service_offerings.py
> This could turn out a bug or limitation, we haven't seen it elsewhere I believe.
Observed error (errorText:VM current state is : PowerOn. But VM should be in PowerOff state.) in test "test_04_change_offering_small" - VM is stopped, and followed by triggering _changeServiceForVirtualMachine_ API. Updated test to confirm the VM 'Stopped' state and trigger the _changeServiceForVirtualMachine_ API. and Re-triggered the smoke tests.
This above test failure/error is not related to the changes in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-758645367
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-776916745
<b>Trillian test result (tid-3519)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44131 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4304-t3519-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 786.04 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-781840749
<b>Trillian test result (tid-3579)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41150 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4304-t3579-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_human_readable_logs.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Smoke tests completed. 84 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_enableHumanReadableLogs | `Error` | 0.29 | test_human_readable_logs.py
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 780.42 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-718739355
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-731980068
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-771556955
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-771556955
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-745405827
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on a change in pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
slavkap commented on a change in pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#discussion_r575648139
##########
File path: server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
##########
@@ -358,9 +363,33 @@ public VMSnapshot allocVMSnapshot(Long vmId, String vsDisplayName, String vsDesc
throw new InvalidParameterValueException("Can not snapshot memory when VM is not in Running state");
}
+ List<VolumeVO> rootVolumes = _volumeDao.findReadyRootVolumesByInstance(userVmVo.getId());
+ if (rootVolumes == null || rootVolumes.isEmpty()) {
+ throw new CloudRuntimeException("Unable to find root volume for the user vm:" + userVmVo.getUuid());
+ }
+
+ VolumeVO rootVolume = rootVolumes.get(0);
+ StoragePoolVO rootVolumePool = _storagePoolDao.findById(rootVolume.getPoolId());
+ if (rootVolumePool == null) {
+ throw new CloudRuntimeException("Unable to find root volume storage pool for the user vm:" + userVmVo.getUuid());
+ }
+
// for KVM, only allow snapshot with memory when VM is in running state
- if (userVmVo.getHypervisorType() == HypervisorType.KVM && userVmVo.getState() == State.Running && !snapshotMemory) {
- throw new InvalidParameterValueException("KVM VM does not allow to take a disk-only snapshot when VM is in running state");
+ if (userVmVo.getHypervisorType() == HypervisorType.KVM) {
+ if (rootVolumePool.getPoolType() != Storage.StoragePoolType.PowerFlex) {
Review comment:
Hi @sureshanaparti, may I suggest here to get the VMSnapshotStrategy instead of checking which is the storage pool type? If it's an instance of DefaultVMSnapshotStrategy to get into the statement. In this case, the other storage plugins could implement their own VM snapshot strategy, without checking here which is the storage pool type. I saw that Solidfire's API has a group snapshot (maybe and others have it). We at StorPool also have this functionality (but for now we have a workaround for this). I guess someday it will be easier for the plugins to adopt this functionality
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-712688028
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-778291821
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-770659669
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2624
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-762134738
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-718738990
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#discussion_r524254789
##########
File path: engine/api/src/main/java/com/cloud/vm/VirtualMachineManager.java
##########
@@ -59,7 +59,13 @@
"The default label name for the config drive", false);
ConfigKey<Boolean> VmConfigDriveOnPrimaryPool = new ConfigKey<>("Advanced", Boolean.class, "vm.configdrive.primarypool.enabled", "false",
- "If config drive need to be created and hosted on primary storage pool. Currently only supported for KVM.", true);
+ "If config drive need to be created and hosted on primary storage pool. Currently only supported for KVM.", true, ConfigKey.Scope.Zone);
Review comment:
> @sureshanaparti this config is changed from global scope to zone. Will that affect the existing setup in any way?
@shwstppr no, the existing config would always fallback to the global scope, as zone scope setting is not defined initially.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-781454011
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#discussion_r524260036
##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
##########
@@ -1465,11 +1543,17 @@ public void prepareForMigration(VirtualMachineProfile vm, DeployDestination dest
long hostId = vm.getVirtualMachine().getHostId();
Host host = _hostDao.findById(hostId);
- volService.grantAccess(volFactory.getVolume(newVol.getId()), host, destPool);
+ try {
+ volService.grantAccess(volFactory.getVolume(newVol.getId()), host, destPool);
+ } catch (Exception e) {
+ throw new StorageAccessException("Unable to grant access to volume: " + newVol.getId() + " on host: " + host.getId());
+ }
Review comment:
> Curious, why we need to catch all _Exception_ here? And we are not even logging it then
@shwstppr in order to retry the deployment, whenever granting access to a disk fails in any case (chances are storage temporarily inaccessible, failure, etc); and this is being logged in "_VirtualMachineManagerImpl orchestrateStart()_"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on a change in pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
slavkap commented on a change in pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#discussion_r575677050
##########
File path: server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
##########
@@ -358,9 +363,33 @@ public VMSnapshot allocVMSnapshot(Long vmId, String vsDisplayName, String vsDesc
throw new InvalidParameterValueException("Can not snapshot memory when VM is not in Running state");
}
+ List<VolumeVO> rootVolumes = _volumeDao.findReadyRootVolumesByInstance(userVmVo.getId());
+ if (rootVolumes == null || rootVolumes.isEmpty()) {
+ throw new CloudRuntimeException("Unable to find root volume for the user vm:" + userVmVo.getUuid());
+ }
+
+ VolumeVO rootVolume = rootVolumes.get(0);
+ StoragePoolVO rootVolumePool = _storagePoolDao.findById(rootVolume.getPoolId());
+ if (rootVolumePool == null) {
+ throw new CloudRuntimeException("Unable to find root volume storage pool for the user vm:" + userVmVo.getUuid());
+ }
+
// for KVM, only allow snapshot with memory when VM is in running state
- if (userVmVo.getHypervisorType() == HypervisorType.KVM && userVmVo.getState() == State.Running && !snapshotMemory) {
- throw new InvalidParameterValueException("KVM VM does not allow to take a disk-only snapshot when VM is in running state");
+ if (userVmVo.getHypervisorType() == HypervisorType.KVM) {
+ if (rootVolumePool.getPoolType() != Storage.StoragePoolType.PowerFlex) {
+ if (userVmVo.getState() == State.Running && !snapshotMemory) {
+ throw new InvalidParameterValueException("KVM VM does not allow to take a disk-only snapshot when VM is in running state");
+ }
+ } else {
+ if (snapshotMemory) {
+ throw new InvalidParameterValueException("Can not snapshot memory for PowerFlex storage pool");
+ }
+
+ // All volumes should be on the same PowerFlex storage pool for VM Snapshot
+ if (!isVolumesOfUserVmOnSameStoragePool(userVmVo.getId(), rootVolumePool.getId())) {
Review comment:
If you consider using VMSnapshotStrategy, this check won't be needed because you're checking in `ScaleIOVMSnapshotStrategy.canHandle()` that all volumes are on PowerFlex. Also, this PR #3724 (if it gets in someday) will handle snapshots of the volumes with different storage pool types
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-781790811
<b>Trillian test result (tid-3577)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32865 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4304-t3577-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_scale_vm | `Failure` | 10.43 | test_scale_vm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#discussion_r579090404
##########
File path: server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
##########
@@ -358,9 +363,33 @@ public VMSnapshot allocVMSnapshot(Long vmId, String vsDisplayName, String vsDesc
throw new InvalidParameterValueException("Can not snapshot memory when VM is not in Running state");
}
+ List<VolumeVO> rootVolumes = _volumeDao.findReadyRootVolumesByInstance(userVmVo.getId());
+ if (rootVolumes == null || rootVolumes.isEmpty()) {
+ throw new CloudRuntimeException("Unable to find root volume for the user vm:" + userVmVo.getUuid());
+ }
+
+ VolumeVO rootVolume = rootVolumes.get(0);
+ StoragePoolVO rootVolumePool = _storagePoolDao.findById(rootVolume.getPoolId());
+ if (rootVolumePool == null) {
+ throw new CloudRuntimeException("Unable to find root volume storage pool for the user vm:" + userVmVo.getUuid());
+ }
+
// for KVM, only allow snapshot with memory when VM is in running state
- if (userVmVo.getHypervisorType() == HypervisorType.KVM && userVmVo.getState() == State.Running && !snapshotMemory) {
- throw new InvalidParameterValueException("KVM VM does not allow to take a disk-only snapshot when VM is in running state");
+ if (userVmVo.getHypervisorType() == HypervisorType.KVM) {
+ if (rootVolumePool.getPoolType() != Storage.StoragePoolType.PowerFlex) {
+ if (userVmVo.getState() == State.Running && !snapshotMemory) {
+ throw new InvalidParameterValueException("KVM VM does not allow to take a disk-only snapshot when VM is in running state");
+ }
+ } else {
+ if (snapshotMemory) {
+ throw new InvalidParameterValueException("Can not snapshot memory for PowerFlex storage pool");
+ }
+
+ // All volumes should be on the same PowerFlex storage pool for VM Snapshot
+ if (!isVolumesOfUserVmOnSameStoragePool(userVmVo.getId(), rootVolumePool.getId())) {
Review comment:
The check here does't allow to create a VMSnapshot object when all the volumes are not on the PowerFlex/ScaleIO pool. ScaleIOVMSnapshotStrategy.canHandle() re-confirms and allows the VM Snapshot operations that are supported by ScaleIOVMSnapshotStrategy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#discussion_r579090278
##########
File path: server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
##########
@@ -358,9 +363,33 @@ public VMSnapshot allocVMSnapshot(Long vmId, String vsDisplayName, String vsDesc
throw new InvalidParameterValueException("Can not snapshot memory when VM is not in Running state");
}
+ List<VolumeVO> rootVolumes = _volumeDao.findReadyRootVolumesByInstance(userVmVo.getId());
+ if (rootVolumes == null || rootVolumes.isEmpty()) {
+ throw new CloudRuntimeException("Unable to find root volume for the user vm:" + userVmVo.getUuid());
+ }
+
+ VolumeVO rootVolume = rootVolumes.get(0);
+ StoragePoolVO rootVolumePool = _storagePoolDao.findById(rootVolume.getPoolId());
+ if (rootVolumePool == null) {
+ throw new CloudRuntimeException("Unable to find root volume storage pool for the user vm:" + userVmVo.getUuid());
+ }
+
// for KVM, only allow snapshot with memory when VM is in running state
- if (userVmVo.getHypervisorType() == HypervisorType.KVM && userVmVo.getState() == State.Running && !snapshotMemory) {
- throw new InvalidParameterValueException("KVM VM does not allow to take a disk-only snapshot when VM is in running state");
+ if (userVmVo.getHypervisorType() == HypervisorType.KVM) {
+ if (rootVolumePool.getPoolType() != Storage.StoragePoolType.PowerFlex) {
Review comment:
@slavkap Thanks for the review and suggestions. Can not get the VMSnapshotStrategy to use here, as VMSnapshot object is not yet created. The check here is a pre-creation phase check, and VMSnapshot object is not created when it is not supported. VMSnapshotStrategy is currently being used to check (_canHandle(VMSnapshot)_) and perform the operations (take VM snapshot, revert VM snapshots, delete VM snapshot) allowed, on the VMSnapshot object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-772155915
<b>Trillian test result (tid-3475)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39980 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4304-t3475-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 84 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_deploy_kubernetes_cluster | `Failure` | 3620.78 | test_kubernetes_clusters.py
test_02_invalid_upgrade_kubernetes_cluster | `Failure` | 76.10 | test_kubernetes_clusters.py
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 0.07 | test_kubernetes_clusters.py
test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 0.06 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.06 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.07 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.07 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.07 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 106.64 | test_kubernetes_clusters.py
test_01_scale_vm | `Failure` | 9.33 | test_scale_vm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-781497515
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-781797496
<b>Trillian test result (tid-3578)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34138 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4304-t3578-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org