You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/28 05:56:17 UTC
[GitHub] [flink] gaoyunhaii opened a new pull request #13272: [FLINK-18695][network] Netty fakes heap buffer allocationn with direct buffers
gaoyunhaii opened a new pull request #13272:
URL: https://github.com/apache/flink/pull/13272
## What is the purpose of the change
This PR modifies the `NettyBufferPool` to also allocate direct buffers for the heap buffer request. This enables us not to change the memory footprint when upgrade Netty to 4.1.50-FINAL. In the future we could further decide how to adjust the Netty memory management.
## Brief change log
- 3ef9f728f6a8005a7f91846bf32df96ee718c626 returns direct buffers for all the heap buffer allocation methods.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13272: [FLINK-18695][network] Netty fakes heap buffer allocationn with direct buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13272:
URL: https://github.com/apache/flink/pull/13272#issuecomment-682346986
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3ef9f728f6a8005a7f91846bf32df96ee718c626",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5952",
"triggerID" : "3ef9f728f6a8005a7f91846bf32df96ee718c626",
"triggerType" : "PUSH"
}, {
"hash" : "d34257206e16c6b9757046cf2c7d71d687ab75eb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5971",
"triggerID" : "d34257206e16c6b9757046cf2c7d71d687ab75eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3ef9f728f6a8005a7f91846bf32df96ee718c626 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5952)
* d34257206e16c6b9757046cf2c7d71d687ab75eb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5971)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13272: [FLINK-18695][network] Netty fakes heap buffer allocationn with direct buffers
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13272:
URL: https://github.com/apache/flink/pull/13272#issuecomment-682346986
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3ef9f728f6a8005a7f91846bf32df96ee718c626",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3ef9f728f6a8005a7f91846bf32df96ee718c626",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3ef9f728f6a8005a7f91846bf32df96ee718c626 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #13272: [FLINK-18695][network] Netty fakes heap buffer allocationn with direct buffers
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #13272:
URL: https://github.com/apache/flink/pull/13272#issuecomment-683366363
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13272: [FLINK-18695][network] Netty fakes heap buffer allocationn with direct buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13272:
URL: https://github.com/apache/flink/pull/13272#issuecomment-682346986
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3ef9f728f6a8005a7f91846bf32df96ee718c626",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5952",
"triggerID" : "3ef9f728f6a8005a7f91846bf32df96ee718c626",
"triggerType" : "PUSH"
}, {
"hash" : "d34257206e16c6b9757046cf2c7d71d687ab75eb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5971",
"triggerID" : "d34257206e16c6b9757046cf2c7d71d687ab75eb",
"triggerType" : "PUSH"
}, {
"hash" : "d34257206e16c6b9757046cf2c7d71d687ab75eb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5988",
"triggerID" : "683366363",
"triggerType" : "MANUAL"
}, {
"hash" : "d34257206e16c6b9757046cf2c7d71d687ab75eb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5971",
"triggerID" : "683366363",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d34257206e16c6b9757046cf2c7d71d687ab75eb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5988) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5971)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13272: [FLINK-18695][network] Netty fakes heap buffer allocationn with direct buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13272:
URL: https://github.com/apache/flink/pull/13272#issuecomment-682346986
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3ef9f728f6a8005a7f91846bf32df96ee718c626",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5952",
"triggerID" : "3ef9f728f6a8005a7f91846bf32df96ee718c626",
"triggerType" : "PUSH"
}, {
"hash" : "d34257206e16c6b9757046cf2c7d71d687ab75eb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5971",
"triggerID" : "d34257206e16c6b9757046cf2c7d71d687ab75eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d34257206e16c6b9757046cf2c7d71d687ab75eb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5971)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13272: [FLINK-18695][network] Netty fakes heap buffer allocationn with direct buffers
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13272:
URL: https://github.com/apache/flink/pull/13272#issuecomment-682341723
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 3ef9f728f6a8005a7f91846bf32df96ee718c626 (Fri Aug 28 05:58:42 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13272: [FLINK-18695][network] Netty fakes heap buffer allocationn with direct buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13272:
URL: https://github.com/apache/flink/pull/13272#issuecomment-682346986
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3ef9f728f6a8005a7f91846bf32df96ee718c626",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5952",
"triggerID" : "3ef9f728f6a8005a7f91846bf32df96ee718c626",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3ef9f728f6a8005a7f91846bf32df96ee718c626 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5952)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #13272: [FLINK-18695][network] Netty fakes heap buffer allocationn with direct buffers
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #13272:
URL: https://github.com/apache/flink/pull/13272#issuecomment-682497831
Very sorry for not checking the tests at the first hand :( , I fixed the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13272: [FLINK-18695][network] Netty fakes heap buffer allocationn with direct buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13272:
URL: https://github.com/apache/flink/pull/13272#issuecomment-682346986
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3ef9f728f6a8005a7f91846bf32df96ee718c626",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5952",
"triggerID" : "3ef9f728f6a8005a7f91846bf32df96ee718c626",
"triggerType" : "PUSH"
}, {
"hash" : "d34257206e16c6b9757046cf2c7d71d687ab75eb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5971",
"triggerID" : "d34257206e16c6b9757046cf2c7d71d687ab75eb",
"triggerType" : "PUSH"
}, {
"hash" : "d34257206e16c6b9757046cf2c7d71d687ab75eb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5988",
"triggerID" : "683366363",
"triggerType" : "MANUAL"
}, {
"hash" : "d34257206e16c6b9757046cf2c7d71d687ab75eb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5971",
"triggerID" : "683366363",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d34257206e16c6b9757046cf2c7d71d687ab75eb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5988) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5971)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13272: [FLINK-18695][network] Netty fakes heap buffer allocationn with direct buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13272:
URL: https://github.com/apache/flink/pull/13272#issuecomment-682346986
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3ef9f728f6a8005a7f91846bf32df96ee718c626",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5952",
"triggerID" : "3ef9f728f6a8005a7f91846bf32df96ee718c626",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3ef9f728f6a8005a7f91846bf32df96ee718c626 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5952)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13272: [FLINK-18695][network] Netty fakes heap buffer allocationn with direct buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13272:
URL: https://github.com/apache/flink/pull/13272#issuecomment-682346986
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3ef9f728f6a8005a7f91846bf32df96ee718c626",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5952",
"triggerID" : "3ef9f728f6a8005a7f91846bf32df96ee718c626",
"triggerType" : "PUSH"
}, {
"hash" : "d34257206e16c6b9757046cf2c7d71d687ab75eb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d34257206e16c6b9757046cf2c7d71d687ab75eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3ef9f728f6a8005a7f91846bf32df96ee718c626 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5952)
* d34257206e16c6b9757046cf2c7d71d687ab75eb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13272: [FLINK-18695][network] Netty fakes heap buffer allocationn with direct buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13272:
URL: https://github.com/apache/flink/pull/13272#issuecomment-682346986
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3ef9f728f6a8005a7f91846bf32df96ee718c626",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5952",
"triggerID" : "3ef9f728f6a8005a7f91846bf32df96ee718c626",
"triggerType" : "PUSH"
}, {
"hash" : "d34257206e16c6b9757046cf2c7d71d687ab75eb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5971",
"triggerID" : "d34257206e16c6b9757046cf2c7d71d687ab75eb",
"triggerType" : "PUSH"
}, {
"hash" : "d34257206e16c6b9757046cf2c7d71d687ab75eb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5988",
"triggerID" : "683366363",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d34257206e16c6b9757046cf2c7d71d687ab75eb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5971) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5988)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #13272: [FLINK-18695][network] Netty fakes heap buffer allocationn with direct buffers
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #13272:
URL: https://github.com/apache/flink/pull/13272
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org