You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Vineet Garg (Jira)" <ji...@apache.org> on 2020/02/14 20:17:00 UTC

[jira] [Commented] (HIVE-22892) Unable to compile query if CTE joined

    [ https://issues.apache.org/jira/browse/HIVE-22892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037268#comment-17037268 ] 

Vineet Garg commented on HIVE-22892:
------------------------------------

[~kkasa] The patch doesn't seem right. With the current patch {{getUnescapedUnqualifiedTableName}} from {{genJoinLogicalPlan}} returns {{TOK_INSERT}} string instead of actual table name. The test works because table name is ignored 
{code}
leftTableAlias = left.getChildCount() == 1 ? tableName : 
            unescapeIdentifier(left.getChild(left.getChildCount() - 1).getText().toLowerCase());
{code}

{{getUnescapedUnqualifiedTableName}} expects ast node of type {{TOK_TABNAME}} but in this case {{TOK_QUERY}} is being passed.

I think we can safely ignore calling {{getUnescapedUnqualifiedTableName}} if {{left.getChildCount}} is not 1 (since the table name it return is being ignored in that case). We should probably also put ASSERT in {{getUnescapedUnqualifiedTableName}} that ast node is always of type {{TOK_TABNAME}}

> Unable to compile query if CTE joined
> -------------------------------------
>
>                 Key: HIVE-22892
>                 URL: https://issues.apache.org/jira/browse/HIVE-22892
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Krisztian Kasa
>            Assignee: Krisztian Kasa
>            Priority: Major
>         Attachments: HIVE-22892.1.patch
>
>
> Repro:
> {code}
> CREATE TABLE t1 (a int, b varchar(100));
> SELECT S.a, t1.a, t1.b FROM (
> WITH
>  sub1 AS (SELECT a, b FROM t1 WHERE b = 'c')
>  SELECT sub1.a, sub1.b FROM sub1
> ) S
> JOIN t1 ON S.a = t1.a;
> {code}
> {code}
> java.lang.AssertionError
> 	at org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.getUnescapedUnqualifiedTableName(BaseSemanticAnalyzer.java:463)
> 	at org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genJoinLogicalPlan(CalcitePlanner.java:2870)
> 	at org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genLogicalPlan(CalcitePlanner.java:5047)
> 	at org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.apply(CalcitePlanner.java:1787)
> 	at org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.apply(CalcitePlanner.java:1734)
> 	at org.apache.calcite.tools.Frameworks.lambda$withPlanner$0(Frameworks.java:130)
> 	at org.apache.calcite.prepare.CalcitePrepareImpl.perform(CalcitePrepareImpl.java:915)
> 	at org.apache.calcite.tools.Frameworks.withPrepare(Frameworks.java:179)
> 	at org.apache.calcite.tools.Frameworks.withPlanner(Frameworks.java:125)
> 	at org.apache.hadoop.hive.ql.parse.CalcitePlanner.logicalPlan(CalcitePlanner.java:1495)
> 	at org.apache.hadoop.hive.ql.parse.CalcitePlanner.genOPTree(CalcitePlanner.java:471)
> 	at org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeInternal(SemanticAnalyzer.java:12550)
> 	at org.apache.hadoop.hive.ql.parse.CalcitePlanner.analyzeInternal(CalcitePlanner.java:361)
> 	at org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:286)
> 	at org.apache.hadoop.hive.ql.Compiler.analyze(Compiler.java:219)
> 	at org.apache.hadoop.hive.ql.Compiler.compile(Compiler.java:103)
> 	at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:197)
> 	at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:810)
> 	at org.apache.hadoop.hive.ql.Driver.compileAndRespond(Driver.java:756)
> 	at org.apache.hadoop.hive.ql.Driver.compileAndRespond(Driver.java:750)
> 	at org.apache.hadoop.hive.ql.reexec.ReExecDriver.compileAndRespond(ReExecDriver.java:125)
> 	at org.apache.hadoop.hive.ql.reexec.ReExecDriver.run(ReExecDriver.java:229)
> 	at org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:249)
> 	at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:193)
> 	at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:415)
> 	at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:346)
> 	at org.apache.hadoop.hive.ql.QTestUtil.executeClientInternal(QTestUtil.java:709)
> 	at org.apache.hadoop.hive.ql.QTestUtil.executeClient(QTestUtil.java:679)
> 	at org.apache.hadoop.hive.cli.control.CoreCliDriver.runTest(CoreCliDriver.java:169)
> 	at org.apache.hadoop.hive.cli.control.CliAdapter.runTest(CliAdapter.java:157)
> 	at org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver(TestCliDriver.java:59)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> 	at org.apache.hadoop.hive.cli.control.CliAdapter$2$1.evaluate(CliAdapter.java:135)
> 	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> 	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
> 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> 	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> 	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> 	at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> 	at org.junit.runners.Suite.runChild(Suite.java:127)
> 	at org.junit.runners.Suite.runChild(Suite.java:26)
> 	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> 	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> 	at org.apache.hadoop.hive.cli.control.CliAdapter$1$1.evaluate(CliAdapter.java:95)
> 	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> 	at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> 	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
> 	at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
> 	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> 	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
> 	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:379)
> 	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:340)
> 	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:125)
> 	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:413)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)