You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Dapeng Sun <da...@intel.com> on 2015/08/19 08:28:31 UTC
Re: Review Request 36836: SENTRY-817: Update processor for generic
model to generate audit log
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36836/#review95833
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java (line 255)
<https://reviews.apache.org/r/36836/#comment150980>
The **tab** should be removed
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java (line 315)
<https://reviews.apache.org/r/36836/#comment150981>
If **jsonLogEntity.toJsonFormatLog()** will throw exception, I think we move or add try-catch around it, so an exception in **toJsonFormatLog()** will not affect others.
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java (line 390)
<https://reviews.apache.org/r/36836/#comment150982>
Same above: If **jsonLogEntity.toJsonFormatLog()** will throw exception, I think we move or add try-catch around it, so an exception in **toJsonFormatLog()** will not affect others.
- Dapeng Sun
On 八月 13, 2015, 1:05 p.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36836/
> -----------------------------------------------------------
>
> (Updated 八月 13, 2015, 1:05 p.m.)
>
>
> Review request for sentry, Dapeng Sun and shen guoquan.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update processor for generic model to generate audit log
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java 94049d8
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessorFactory.java 71ce579
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessorWrapper.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java ea9fae9
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestAuditLogForSentryGenericService.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36836/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>