[jira] [Commented] (GEODE-3961) Show metrics disregards specified --categories for CacheServer (--port option related) metrics

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248015#comment-16248015 ] 

ASF GitHub Bot commented on GEODE-3961:
---------------------------------------

PurelyApplied opened a new pull request #1046: GEODE-3961: Refactor ShowMetricsCommand to behave uniformly...
URL: https://github.com/apache/geode/pull/1046
 
 
   ... when --categories is provided.
   
   * The ShowMetricsCommand has been almost entirely refactored, but with minimal change to existing behavior.
   * The category "cache-server" has been renamed to "cacheserver"
   * The "query" category now only lists once instead of twice.
   * Category checking is now performed by the client, not the server.
   * Expand test coverage
   * Associated help updated and corrected.
   * Alphabetized excludedClasses.txt
   
   -----
   
   I realize the alphabetization of `excludedClasses.txt` is well beyond the scope of this ticket, but it seemed harmless at the time.  I can revert that change to a one-line addition if that is the desire of the community.  Or I could open a new ticket and address it in that.
   
   Technically, this is contains a behavior change in that `--categories=cache-server` was a valid option that should now be expressed as `--categories=cacheserver`.  For the sake and stability of using an `Enum`, the dash is prohibited.  A special case could be added to allow this legacy behavior to remain, stripping hyphens from the input string, but that seemed to be more special-case handling than was warranted.
   
   ------
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Show metrics disregards specified --categories for CacheServer (--port option related) metrics 
> -----------------------------------------------------------------------------------------------
>
>                 Key: GEODE-3961
>                 URL: https://issues.apache.org/jira/browse/GEODE-3961
>             Project: Geode
>          Issue Type: Bug
>            Reporter: Patrick Rhomberg
>
> Those CacheServer metric categories ({{query}}, {{notification}}, and {{cache-server}}) are not checked against those categories specified by the user and are only checked against the cache server bean being non-null (implicitly: that the port was provided and valid).
> For unification and consistency, these categories should not be displayed when the {{--categories}} option is specified and excludes them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)