You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/04/27 13:15:56 UTC

[GitHub] [netbeans] singh-akhilesh opened a new pull request #2107: Pack200 remove from nb installer

singh-akhilesh opened a new pull request #2107:
URL: https://github.com/apache/netbeans/pull/2107


   https://issues.apache.org/jira/browse/NETBEANS-3985


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] jlahoda commented on a change in pull request #2107: Pack200 remove from nb installer

Posted by GitBox <gi...@apache.org>.
jlahoda commented on a change in pull request #2107:
URL: https://github.com/apache/netbeans/pull/2107#discussion_r416343953



##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/MakeNBM.java
##########
@@ -334,14 +334,14 @@ public void setProductDir( File dir ) {
     public void setFile(File file) {
         this.file = file;
     }
-
-    public void setUsePack200(boolean usePack200) {
+    //Commented below code, as pack200 is not supported from jdk 14 onwards

Review comment:
       I guess the methods (and so their attributes in the build.xml) should stay here, for compatibility. They, of course, won't do anything.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] rcpacheco commented on pull request #2107: Pack200 remove from nb installer

Posted by GitBox <gi...@apache.org>.
rcpacheco commented on pull request #2107:
URL: https://github.com/apache/netbeans/pull/2107#issuecomment-620110319


   I also think that it is better to eliminate the old code, than to leave the code commented. I think that the proyect has a coding style guideline, but don't know where it is. Also, there are other modules that use Pack200, like netbeans-mavenutils-nbm-maven-plugin , see org.apache.netbeans.nbm.CreateClusterAppMojo


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] graben commented on pull request #2107: Pack200 remove from nb installer

Posted by GitBox <gi...@apache.org>.
graben commented on pull request #2107:
URL: https://github.com/apache/netbeans/pull/2107#issuecomment-620067377


   @singh-akhilesh:
   What's the benefit of commenting rather than deleting the code? Nobody will change it and history is still available.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] singh-akhilesh commented on pull request #2107: Pack200 remove from nb installer

Posted by GitBox <gi...@apache.org>.
singh-akhilesh commented on pull request #2107:
URL: https://github.com/apache/netbeans/pull/2107#issuecomment-621158558


   > @singh-akhilesh:
   > What's the benefit of commenting rather than deleting the code? Nobody will change it and history is still available.
   
   Agree. Deleted the previously commented code.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] singh-akhilesh commented on pull request #2107: Pack200 remove from nb installer

Posted by GitBox <gi...@apache.org>.
singh-akhilesh commented on pull request #2107:
URL: https://github.com/apache/netbeans/pull/2107#issuecomment-621161164


   @ebarboni Please consider this PR as a candidate of 12.0 release.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] ebarboni commented on pull request #2107: Pack200 remove from nb installer

Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #2107:
URL: https://github.com/apache/netbeans/pull/2107#issuecomment-621237216


   yep merging on beta 4 we may try the installer (the untrusted one) to check on jdk14


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] singh-akhilesh commented on a change in pull request #2107: Pack200 remove from nb installer

Posted by GitBox <gi...@apache.org>.
singh-akhilesh commented on a change in pull request #2107:
URL: https://github.com/apache/netbeans/pull/2107#discussion_r416359306



##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/MakeNBM.java
##########
@@ -334,14 +334,14 @@ public void setProductDir( File dir ) {
     public void setFile(File file) {
         this.file = file;
     }
-
-    public void setUsePack200(boolean usePack200) {
+    //Commented below code, as pack200 is not supported from jdk 14 onwards

Review comment:
       Indeed, i'll address this comment.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] arvindaprameya commented on pull request #2107: Pack200 remove from nb installer

Posted by GitBox <gi...@apache.org>.
arvindaprameya commented on pull request #2107:
URL: https://github.com/apache/netbeans/pull/2107#issuecomment-623297770


   + 1 Approved, Thanks for completing this Akhilesh


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] singh-akhilesh commented on a change in pull request #2107: Pack200 remove from nb installer

Posted by GitBox <gi...@apache.org>.
singh-akhilesh commented on a change in pull request #2107:
URL: https://github.com/apache/netbeans/pull/2107#discussion_r417260536



##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/MakeNBM.java
##########
@@ -334,14 +334,14 @@ public void setProductDir( File dir ) {
     public void setFile(File file) {
         this.file = file;
     }
-
-    public void setUsePack200(boolean usePack200) {
+    //Commented below code, as pack200 is not supported from jdk 14 onwards

Review comment:
       Addressed code review comments and removed all the previously commented code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] rcpacheco commented on pull request #2107: Pack200 remove from nb installer

Posted by GitBox <gi...@apache.org>.
rcpacheco commented on pull request #2107:
URL: https://github.com/apache/netbeans/pull/2107#issuecomment-620311709


   There seems to be an error with the creation of the Visual Studio Code extension: [exec] [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.6.0:java (default-cli) on project prepare-bundles: An exception occured while executing the Java class. Cannot find license for: agent-base


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] graben commented on pull request #2107: Pack200 remove from nb installer

Posted by GitBox <gi...@apache.org>.
graben commented on pull request #2107:
URL: https://github.com/apache/netbeans/pull/2107#issuecomment-620406764


   > There seems to be an error with the creation of the Visual Studio Code extension: [exec] [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.6.0:java (default-cli) on project prepare-bundles: An exception occured while executing the Java class. Cannot find license for: agent-base
   
   Have a look on #2105


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists