[jira] [Commented] (IMPALA-7317) Instant validation job that runs on Gerrit upload (clang tidy, other simple checks)

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-7317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565674#comment-16565674 ] 

ASF subversion and git services commented on IMPALA-7317:
---------------------------------------------------------

Commit 55083f38cce74347a3a528dd59c402f5cfd4441a in impala's branch refs/heads/master from [~tarmstrong@cloudera.com]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=55083f3 ]

IMPALA-7317: comment on long lines and whitespace

Add some basic formatting checks that can be implemented
easily by parsing the diff line-by-line. These are applied
to Java, Python, C++, shell and thrift source files with
some exclusions.

Adds a --dryrun option that does not try to post back the
comments to gerrit.

Remove the option to specify a git revision since flake8-diff doesn't
work correctly when run on source that isn't checked out.

Testing:
Added some violations to this code change that will be
fixed before merging. The output is:

  {
   "comments": {
    "bin/jenkins/critique-gerrit-review.py": [
     {
      "message": "flake8: E501 line too long (107 > 90 characters)",
      "range": {
       "start_character": 90,
       "start_line": 124,
       "end_line": 124,
       "end_character": 91
      }
     },
     {
      "message": "tab used for whitespace",
      "line": 125
     }
    ]
   }
  }

Change-Id: I36bb99560ab09d7753ff93227d1c4972582770f2
Reviewed-on: http://gerrit.cloudera.org:8080/11085
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>


> Instant validation job that runs on Gerrit upload (clang tidy, other simple checks)
> -----------------------------------------------------------------------------------
>
>                 Key: IMPALA-7317
>                 URL: https://issues.apache.org/jira/browse/IMPALA-7317
>             Project: IMPALA
>          Issue Type: Task
>            Reporter: Tim Armstrong
>            Assignee: Tim Armstrong
>            Priority: Major
>
> Add a new job to jenkins.impala.io that runs clang tidy upon upload to Gerrit. The goal is to prefetch any obvious failures that will prevent the code being merged.
> Existing checks that are reasonably cheap:
> * clang-tidy-ub1604
> * ubuntu-16.04-build-only
> * rat-check-ub1604
> Look into other checks to add (flake8, lines too long, etc)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org