You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/22 10:35:40 UTC
[GitHub] [beam] mosche opened a new pull request, #21982: [#21634] Add comments on FieldValueGetter.
mosche opened a new pull request, #21982:
URL: https://github.com/apache/beam/pull/21982
Follow up on https://github.com/apache/beam/pull/17172, adding some missing comments.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a diff in pull request #21982: [#21634] Add comments on FieldValueGetter.
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on code in PR #21982:
URL: https://github.com/apache/beam/pull/21982#discussion_r904047942
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/values/Row.java:
##########
@@ -106,7 +106,7 @@ public abstract class Row implements Serializable {
/** Return the size of data fields. */
public abstract int getFieldCount();
- /** Return the list of data values. */
Review Comment:
Could you clarify the meaning of "raw" here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mosche commented on a diff in pull request #21982: [#21634] Add comments on FieldValueGetter.
Posted by GitBox <gi...@apache.org>.
mosche commented on code in PR #21982:
URL: https://github.com/apache/beam/pull/21982#discussion_r907159504
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/values/Row.java:
##########
@@ -106,7 +106,7 @@ public abstract class Row implements Serializable {
/** Return the size of data fields. */
public abstract int getFieldCount();
- /** Return the list of data values. */
Review Comment:
I've updated the comment @TheNeuralBit. For context, here's @reuvenlax's explanation of `getValues`.
From that it sounds like this shouldn't be publicly consumed and should also be annotated with `@Internal`.
> getValues() is maybe poorly named - might be better called getRawValues. What you're looking for is probably the getBaseValues() method.
> getValues is mostly used in code that knows exactly what it's doing for optimization purposes. It goes along with the attachValues method, which is similarly tricky to use. It's there to enable 0-copy code, but not necessarily intended for general consumption.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit merged pull request #21982: [#21634] Add comments on FieldValueGetter.
Posted by GitBox <gi...@apache.org>.
TheNeuralBit merged PR #21982:
URL: https://github.com/apache/beam/pull/21982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org