[GitHub] [trafficserver] sudheerv commented on a change in pull request #7768: Issue 7767 - Short circuit remap reload when non-existent remap file is specified

[GitBox <gi...@apache.org>]

sudheerv commented on a change in pull request #7768:
URL: https://github.com/apache/trafficserver/pull/7768#discussion_r625402107



##########
File path: proxy/http/remap/RemapConfig.cc
##########
@@ -949,7 +949,7 @@ remap_parse_config_bti(const char *path, BUILD_TABLE_INFO *bti)
     switch (ec.value()) {
     case ENOENT:
       Warning("Can't open remapping configuration file %s - %s", path, strerror(ec.value()));
-      break;
+      return true;

Review comment:
       I had `false` earlier but, that fails some autest that seems to expect true for a non-existent file.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org