You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2016/03/20 09:09:50 UTC

Review Request 45079: RANGER-889: Policy engine API to find list of users/groups having access to a resource

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45079/
-----------------------------------------------------------

Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Bugs: RANGER-889
    https://issues.apache.org/jira/browse/RANGER-889


Repository: ranger


Description
-------

Added the following method to RangerBasePlugin class:
 - RangerResourceAccessInfo getResourceAccessInfo(RangerAccessRequest request)


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java 497c344 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java d2b3a5c 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceAccessInfo.java PRE-CREATION 
  agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyItemEvaluator.java a986ca6 
  agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java 9f60b7b 
  agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java 624ff1c 
  agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyItemEvaluator.java 9bbe4e3 
  agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java 2afe0e6 
  agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java 59b7479 
  agents-common/src/test/resources/policyengine/test_policyengine_resource_access_info.json PRE-CREATION 

Diff: https://reviews.apache.org/r/45079/diff/


Testing
-------

Added unit tests to validate the new method.


Thanks,

Madhan Neethiraj


Re: Review Request 45079: RANGER-889: Policy engine API to find list of users/groups having access to a resource

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45079/
-----------------------------------------------------------

(Updated March 21, 2016, 6:18 p.m.)


Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Changes
-------

Renamed the new method to RangerPolicyItemEvaltor.getResourceAccessInfo() - to make it easily extendable, especially in master to return list of denied users/groups.


Bugs: RANGER-889
    https://issues.apache.org/jira/browse/RANGER-889


Repository: ranger


Description
-------

Added the following method to RangerBasePlugin class:
 - RangerResourceAccessInfo getResourceAccessInfo(RangerAccessRequest request)


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java bff16c9 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java b45358d 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceAccessInfo.java PRE-CREATION 
  agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyItemEvaluator.java a986ca6 
  agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java d570c6c 
  agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java e6ec2ad 
  agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyItemEvaluator.java 9bbe4e3 
  agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java 5f98b79 
  agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java 59b7479 
  agents-common/src/test/resources/policyengine/test_policyengine_resource_access_info.json PRE-CREATION 

Diff: https://reviews.apache.org/r/45079/diff/


Testing
-------

Added unit tests to validate the new method.


Thanks,

Madhan Neethiraj


Re: Review Request 45079: RANGER-889: Policy engine API to find list of users/groups having access to a resource

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45079/#review124584
-----------------------------------------------------------


Ship it!




Ship It!

- Ramesh Mani


On March 20, 2016, 8:09 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45079/
> -----------------------------------------------------------
> 
> (Updated March 20, 2016, 8:09 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-889
>     https://issues.apache.org/jira/browse/RANGER-889
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Added the following method to RangerBasePlugin class:
>  - RangerResourceAccessInfo getResourceAccessInfo(RangerAccessRequest request)
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java 497c344 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java d2b3a5c 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceAccessInfo.java PRE-CREATION 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyItemEvaluator.java a986ca6 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java 9f60b7b 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java 624ff1c 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyItemEvaluator.java 9bbe4e3 
>   agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java 2afe0e6 
>   agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java 59b7479 
>   agents-common/src/test/resources/policyengine/test_policyengine_resource_access_info.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45079/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests to validate the new method.
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>