[GitHub] [arrow-datafusion] liukun4515 commented on a diff in pull request #3444: Evaluate expressions after type coercion

[GitBox <gi...@apache.org>]

liukun4515 commented on code in PR #3444:
URL: https://github.com/apache/arrow-datafusion/pull/3444#discussion_r967911124


##########
datafusion/core/tests/sql/aggregates.rs:
##########
@@ -1834,11 +1834,11 @@ async fn aggregate_avg_add() -> Result<()> {
     assert_eq!(results.len(), 1);
 
     let expected = vec![
-        "+--------------+-------------------------+-------------------------+-------------------------+",
-        "| AVG(test.c1) | AVG(test.c1) + Int64(1) | AVG(test.c1) + Int64(2) | Int64(1) + AVG(test.c1) |",
-        "+--------------+-------------------------+-------------------------+-------------------------+",
-        "| 1.5          | 2.5                     | 3.5                     | 2.5                     |",
-        "+--------------+-------------------------+-------------------------+-------------------------+",
+        "+--------------+---------------------------+---------------------------+---------------------------+",

Review Comment:
   I just have the comments about the header of the expr.
   The input sql is  `AGG(C1) + 1`, `1` is the int64 data type, but the header is convert to float after casted



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org