You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/12/03 17:01:41 UTC
[GitHub] [carbondata] Indhumathi27 opened a new pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Indhumathi27 opened a new pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039
### Why is this PR needed?
### What changes were proposed in this PR?
### Does this PR introduce any user interface change?
- No
- Yes. (please explain the change and update document)
### Is any new testcase added?
- No
- Yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-738200415
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5052/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739492660
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5082/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739714799
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5094/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [CARBONDATA-4077] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739817903
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3324/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4039: [CARBONDATA-4077] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-745974311
@kunal642 Please review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [CARBONDATA-4077] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-740009950
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3337/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] kunal642 commented on a change in pull request #4039: [CARBONDATA-4077] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
kunal642 commented on a change in pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#discussion_r539852924
##########
File path: processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/FileMergeSortComparator.java
##########
@@ -78,49 +83,43 @@ public int compare(IntermediateSortTempRow rowA, IntermediateSortTempRow rowB) {
int nonDictIndex = 0;
int noDicTypeIdx = 0;
int schemaRowIdx = 0;
- int sortIndex = 0;
- for (Map.Entry<Integer, List<Boolean>> schemaEntry : sortColumnSchemaOrderMap.entrySet()) {
- boolean isSortColumn = schemaEntry.getValue().get(0);
- boolean isDictColumn = schemaEntry.getValue().get(1);
- if (isSortColumn) {
- if (isSortColumnNoDictionary[sortIndex++]) {
- if (DataTypeUtil.isPrimitiveColumn(noDictDataTypes[noDicTypeIdx])) {
- // use data types based comparator for the no dictionary measure columns
- SerializableComparator comparator =
- org.apache.carbondata.core.util.comparator.Comparator
- .getComparator(noDictDataTypes[noDicTypeIdx]);
- int difference = comparator
- .compare(rowA.getNoDictSortDims()[noDictPrimitiveIndex[schemaRowIdx]],
- rowB.getNoDictSortDims()[noDictPrimitiveIndex[schemaRowIdx]]);
- schemaRowIdx++;
- if (difference != 0) {
- return difference;
- }
- } else {
- byte[] byteArr1 = (byte[]) rowA.getNoDictSortDims()[nonDictIndex];
- byte[] byteArr2 = (byte[]) rowB.getNoDictSortDims()[nonDictIndex];
-
- int difference = ByteUtil.UnsafeComparer.INSTANCE.compareTo(byteArr1, byteArr2);
- if (difference != 0) {
- return difference;
- }
+ for (boolean isNoDictionary : isSortColumnNoDictionary) {
Review comment:
i think now "isSortColumnNoDictionary" is not needed as dict and noDict Order mappings are kept separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739313044
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5081/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739486536
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5058/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739480240
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739483872
Retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739688329
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3338/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [CARBONDATA-4077] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739818831
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5085/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739660102
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-738619646
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3300/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] asfgit closed pull request #4039: [CARBONDATA-4077] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739486393
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3301/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [CARBONDATA-4077] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-742337441
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3372/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739664975
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3313/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [CARBONDATA-4077] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739818292
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5105/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4039: [CARBONDATA-4077] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-745974586
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] kunal642 commented on pull request #4039: [CARBONDATA-4077] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
kunal642 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-747391818
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [CARBONDATA-4077] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-746104802
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5180/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739492808
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3325/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] brijoobopanna commented on pull request #4039: [CARBONDATA-4077] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
brijoobopanna commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739941231
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [CARBONDATA-4077] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-746116752
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3418/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [CARBONDATA-4077] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-742330700
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5134/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-738201557
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3293/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739313184
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3324/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739688118
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5073/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4039: [CARBONDATA-4077] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#discussion_r539876147
##########
File path: processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/FileMergeSortComparator.java
##########
@@ -78,49 +83,43 @@ public int compare(IntermediateSortTempRow rowA, IntermediateSortTempRow rowB) {
int nonDictIndex = 0;
int noDicTypeIdx = 0;
int schemaRowIdx = 0;
- int sortIndex = 0;
- for (Map.Entry<Integer, List<Boolean>> schemaEntry : sortColumnSchemaOrderMap.entrySet()) {
- boolean isSortColumn = schemaEntry.getValue().get(0);
- boolean isDictColumn = schemaEntry.getValue().get(1);
- if (isSortColumn) {
- if (isSortColumnNoDictionary[sortIndex++]) {
- if (DataTypeUtil.isPrimitiveColumn(noDictDataTypes[noDicTypeIdx])) {
- // use data types based comparator for the no dictionary measure columns
- SerializableComparator comparator =
- org.apache.carbondata.core.util.comparator.Comparator
- .getComparator(noDictDataTypes[noDicTypeIdx]);
- int difference = comparator
- .compare(rowA.getNoDictSortDims()[noDictPrimitiveIndex[schemaRowIdx]],
- rowB.getNoDictSortDims()[noDictPrimitiveIndex[schemaRowIdx]]);
- schemaRowIdx++;
- if (difference != 0) {
- return difference;
- }
- } else {
- byte[] byteArr1 = (byte[]) rowA.getNoDictSortDims()[nonDictIndex];
- byte[] byteArr2 = (byte[]) rowB.getNoDictSortDims()[nonDictIndex];
-
- int difference = ByteUtil.UnsafeComparer.INSTANCE.compareTo(byteArr1, byteArr2);
- if (difference != 0) {
- return difference;
- }
+ for (boolean isNoDictionary : isSortColumnNoDictionary) {
Review comment:
yes. Removed it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-738618787
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5059/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [CARBONDATA-4077] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739819148
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3350/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [CARBONDATA-4077] Refactor and Fix Insert into partition issue with FileMergeSortComparator
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4039:
URL: https://github.com/apache/carbondata/pull/4039#issuecomment-740009799
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5098/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org