You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by "Joel Richard (JIRA)" <ji...@apache.org> on 2015/06/12 16:13:00 UTC

[jira] [Comment Edited] (SLING-4584) Performance: XSSAPI.getValidHref should not be based on HTML filtering

    [ https://issues.apache.org/jira/browse/SLING-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14583430#comment-14583430 ] 

Joel Richard edited comment on SLING-4584 at 6/12/15 2:12 PM:
--------------------------------------------------------------

[~asanso], would you mind committing the attached patch? It has already been reviewed by [~chaotic]. In my case it improves the overall rendering time by 6%.


was (Author: joelrich):
[~asanso], would you mind committing the attached patch? It has already been reviewed by [~chaotic].

> Performance: XSSAPI.getValidHref should not be based on HTML filtering
> ----------------------------------------------------------------------
>
>                 Key: SLING-4584
>                 URL: https://issues.apache.org/jira/browse/SLING-4584
>             Project: Sling
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: XSS Protection API 1.0.2
>            Reporter: Joel Richard
>              Labels: perfomance, xss
>             Fix For: XSS Protection API 1.0.4
>
>         Attachments: 0001-SLING-4584-Performance-XSSAPI.getValidHref-should-no.patch
>
>
> Around 3% of the rendering time is spent in getValidHref because it uses AntiSamy (which is a HTML filter) to do the job. This is obviously a hack and adds a lot of unnecessary overhead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)