[kudu-CR] KUDU-1809: Add batch size configuration for ScanToken API

["Dan Burkert (Code Review)" <ge...@cloudera.org>]

Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8435 )

Change subject: KUDU-1809: Add batch size configuration for ScanToken API
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/8435/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java:

http://gerrit.cloudera.org:8080/#/c/8435/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@657
PS1, Line 657:     KuduScanToken.KuduScanTokenBuilder tokenBuilder =
This is setting the option, but it's not testing that it's actually taking effect.  I think you could test it by starting one of the scanners and ensuring the number of batches is what you'd expect for a low batch size.


http://gerrit.cloudera.org:8080/#/c/8435/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@659
PS1, Line 659:                   .batchSizeBytes(100); // Just a hint for batch size.
To keep the style consistent with the line below, split this into a separate statement on its own line ('tokenBuilder.batchSizeBytes(100);')


http://gerrit.cloudera.org:8080/#/c/8435/1/src/kudu/client/scan_token-test.cc
File src/kudu/client/scan_token-test.cc:

http://gerrit.cloudera.org:8080/#/c/8435/1/src/kudu/client/scan_token-test.cc@182
PS1, Line 182:     ASSERT_OK(builder.SetBatchSizeBytes(100));  // Just a hint for batch size.
Likewise, this isn't ensuring that the batch size takes effect.



-- 
To view, visit http://gerrit.cloudera.org:8080/8435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie147ba4aa8e457c7063f7bb5b51b4e7e0bd1fe73
Gerrit-Change-Number: 8435
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 01 Nov 2017 18:01:40 +0000
Gerrit-HasComments: Yes