You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/02/23 13:10:45 UTC
[GitHub] [skywalking] wu-sheng opened a new issue #4401: [NIGNX-LUA] e2e
test for Nginx lua agent
wu-sheng opened a new issue #4401: [NIGNX-LUA] e2e test for Nginx lua agent
URL: https://github.com/apache/skywalking/issues/4401
One hand, we will initial a new e2e in the main repo, to test the nginx with java agent. I have added this suggestions in #4399 to @JaredTan95
Also, in the nginx lua repo, we should consider how to test it, right now, the `example/nginx.config` could be a tracing tier1 + tier2 LBs, mock backend service and mock OAP backend. The trace will be reported and output in the nginx log.
@kezhenxu94 @dmsolr @arugal @aderm Any suggestion about how to do this?
My idea is trying to output the trace into the file, and use some trace check tool to do this? Such as the main repo test tool? @dmsolr I think you are quite familiar with this. Could you consider to lead this part?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] dmsolr commented on issue #4401: [NIGNX-LUA] e2e test
for Nginx lua agent
Posted by GitBox <gi...@apache.org>.
dmsolr commented on issue #4401: [NIGNX-LUA] e2e test for Nginx lua agent
URL: https://github.com/apache/skywalking/issues/4401#issuecomment-590131442
I am happy to do this.
We have 2 parts here, right?
1. set up IT/UT nginx-agent on the skywalking-nginx-lua repo.
2. set up e2e (like java agent plugin) on the main repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng closed issue #4401: [NIGNX-LUA] e2e test for
Nginx lua agent
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #4401: [NIGNX-LUA] e2e test for Nginx lua agent
URL: https://github.com/apache/skywalking/issues/4401
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4401: [NIGNX-LUA] e2e
test for Nginx lua agent
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4401: [NIGNX-LUA] e2e test for Nginx lua agent
URL: https://github.com/apache/skywalking/issues/4401#issuecomment-590132598
@dmsolr about the e2e in the nginx lua repo, I hope we could do that in the lightweight way. Just use a container to run openresty, and output the existing trace into the file. Then we could use the existing tool to check.
But the tool codes have to been copied to there, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] dmsolr commented on issue #4401: [NIGNX-LUA] e2e test
for Nginx lua agent
Posted by GitBox <gi...@apache.org>.
dmsolr commented on issue #4401: [NIGNX-LUA] e2e test for Nginx lua agent
URL: https://github.com/apache/skywalking/issues/4401#issuecomment-590133482
to validate the log file, the Nginx printed, is not difficult. We can re-use the validation-tools.
I ran the nginx-lua, but I cannot found the trace information in the log.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4401: [NIGNX-LUA] e2e
test for Nginx lua agent
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4401: [NIGNX-LUA] e2e test for Nginx lua agent
URL: https://github.com/apache/skywalking/issues/4401#issuecomment-590132252
Most UT has been included and tested in the nginx-lua repo. I have added.
This issue is only about e2e in the lua repo.
E2e in main repo should be a part of @JaredTan95 HTTP PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] dmsolr edited a comment on issue #4401: [NIGNX-LUA]
e2e test for Nginx lua agent
Posted by GitBox <gi...@apache.org>.
dmsolr edited a comment on issue #4401: [NIGNX-LUA] e2e test for Nginx lua agent
URL: https://github.com/apache/skywalking/issues/4401#issuecomment-590133482
to validate the log file, the Nginx printed, is not difficult. We can re-use the validation-tools.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4401: [NIGNX-LUA] e2e
test for Nginx lua agent
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4401: [NIGNX-LUA] e2e test for Nginx lua agent
URL: https://github.com/apache/skywalking/issues/4401#issuecomment-593858044
Have provided by @dmsolr . Once the 7.0.0 HTTP APIs are ready, I am going to initial the release. FYI @JaredTan95 @arugal
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services