[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1420: libc: Don't define localtime[_r] to macro when CONFIG_LIBC_LOCALTIME not define

[GitBox <gi...@apache.org>]

btashton commented on a change in pull request #1420:
URL: https://github.com/apache/incubator-nuttx/pull/1420#discussion_r456953053



##########
File path: arch/renesas/src/rx65n/rx65n_rtc.c
##########
@@ -774,7 +774,6 @@ int up_rtc_settime(FAR const struct timespec *tp)
 
   /* Day of the week (0-6, 0=Sunday) */
 
-#if defined(CONFIG_LIBC_LOCALTIME) || defined(CONFIG_TIME_EXTENDED)

Review comment:
       Should this be just conditional on CONFIG_TIME_EXTENDED now?

##########
File path: arch/renesas/src/rx65n/rx65n_rtc.c
##########
@@ -1355,9 +1353,7 @@ int up_rtc_getdatetime(FAR struct tm *tp)
 
       /* Days since Sunday (0-6) */
 
-#if defined(CONFIG_LIBC_LOCALTIME) || defined(CONFIG_TIME_EXTENDED)

Review comment:
       Same question




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org