You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "samarth-ksolves (via GitHub)" <gi...@apache.org> on 2025/10/10 09:03:47 UTC

[PR] KAFKA-19777 : Generator | Fix order of arguments to assertEquals in unit tests [kafka]

samarth-ksolves opened a new pull request, #20679:
URL: https://github.com/apache/kafka/pull/20679

   In this PR, we corrected the argument order in assertEquals within the tools package.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-19777 : Generator | Fix order of arguments to assertEquals in unit tests [kafka]

Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on PR #20679:
URL: https://github.com/apache/kafka/pull/20679#issuecomment-3448650580

   Please merge latest changes from trunk.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-19777 : Generator | Fix order of arguments to assertEquals in unit tests [kafka]

Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on PR #20679:
URL: https://github.com/apache/kafka/pull/20679#issuecomment-3532269540

   @samarth-ksolves This PR has got out of hand since the latest merge. I suggest closing it and making a fresh PR on the current trunk with just the changes that you intended for this PR. That will be much more viable to review and merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-19777 : Generator | Fix order of arguments to assertEquals in unit tests [kafka]

Posted by "abhi-ksolves (via GitHub)" <gi...@apache.org>.
abhi-ksolves commented on PR #20679:
URL: https://github.com/apache/kafka/pull/20679#issuecomment-3444018057

   @AndrewJSchofield 
   Changes Updated


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-19777 : Generator | Fix order of arguments to assertEquals in unit tests [kafka]

Posted by "samarth-ksolves (via GitHub)" <gi...@apache.org>.
samarth-ksolves closed pull request #20679: KAFKA-19777 : Generator | Fix order of arguments to assertEquals in unit tests
URL: https://github.com/apache/kafka/pull/20679


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-19777 : Generator | Fix order of arguments to assertEquals in unit tests [kafka]

Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on code in PR #20679:
URL: https://github.com/apache/kafka/pull/20679#discussion_r2425677214


##########
generator/src/test/java/org/apache/kafka/message/CodeBufferTest.java:
##########
@@ -41,10 +41,11 @@ public void testWrite() throws Exception {
         StringWriter stringWriter = new StringWriter();
         buffer.write(stringWriter);
         assertEquals(
-            stringWriter.toString(),
             String.format("public static void main(String[] args) throws Exception {%n") +
             String.format("    System.out.println(\"hello world\");%n") +
-            String.format("}%n"));
+            String.format("}%n"), stringWriter.toString());
+

Review Comment:
   nit: Extra blank lines should be removed please.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org